Bug 1060834

Summary:	Consistently use "Deleted" in REST responses
Product:	OpenShift Online	Reporter:	Oleg Fayans <ofayans>
Component:	Master	Assignee:	Dan McPherson <dmcphers>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.x	CC:	amarecek, dmcphers, jhou
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1067308 (view as bug list)		Environment:
Last Closed:	2014-03-12 03:06:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1067308

Description Oleg Fayans 2014-02-03 17:45:25 UTC

Description of problem:
We should use the similar output messages for actions of the same kind. For example, when I delete an ssh key via REST, it tells me "Deleted SSH key", 
When I delete the authorization token, it says "Authorization <%token_id%> is revoked", when I delete an alias, it says: "Removed alias.com from application"
Let's put some consistency to the REST responses
 
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Dan McPherson 2014-02-06 19:26:58 UTC

I disagree that everything should be deleted.  Consistency within a type if important.  We don't want to use both delete and destroy and remove for one type of object.  But revoke is a better word for auth.  I actually like removed better for alias and I would prefer removed for ssh key.  The reason why is because remove implies the app is still there and you have taken something away from it.  You aren't actually deleting the key.  It still exists.  It's just not a part of the app.  I went ahead and changed it for ssh key.


https://github.com/openshift/origin-server/pull/4676

Comment 2 openshift-github-bot 2014-02-06 20:29:20 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/778abb6623737875b162d2dbb700fb2ab6c00416
Bug 1060834

Comment 3 Jianwei Hou 2014-02-07 05:21:18 UTC

Verified on devenv_4341, the RESTAPI messages have been improved when an sshkey is deleted.

{"api_version":1.6,"data":null,"messages":[{"exit_code":0,"field":null,"index":null,"severity":"info","text":"Removed SSH key default"}],"status":"ok","supported_api_versions":[1.0,1.1,1.2,1.3,1.4,1.5,1.6],"type":null,"version":"1.6"}