Bug 1061747
| Summary: | Review Request: collections-generic - A generics-enabled version of Apache Commons-Collections | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Rati <rrati> |
| Component: | Package Review | Assignee: | Haïkel Guémar <karlthered> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | karlthered, mizdebsk, package-review |
| Target Milestone: | --- | Flags: | karlthered:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-04-09 14:08:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1010003, 1069366, 1071456 | ||
|
Description
Robert Rati
2014-02-05 14:34:12 UTC
Please change the description and use Apache instead of Jakarta. Jakarta project [1] has been retired long time ago and COmmons is now a top-level apache project. [1] https://jakarta.apache.org/ Also, given that this project is a fork of Apache Commons (already packaged) and it wasn't updated in a while (last svn activity is 2007-02-12) I would recommend not to package it, but use Apache Commons instead. updated in place and replaced Jakarta with Apache I understand Mikolaj concerns, but from a quick code review, apache commons collections 4.0 could not be used as a drop-in replacement of collections-generic. Maybe, it won't be much complicated to move to latest ACC release (which now supports java generics) but it will require more scrutiny. Since we already package multiple releases of java packages for other and it's a proper fork (and not bundling), couldn't we settle it by opening a ticket upstream considering to move to ACC 4.0 ? Getting Oozie in is critical for the Cloud product big data image. If nobody complains, I'll move forward this review this week. I'd hold off on this review. The package has compilation issues on java8 and I am working on porting jung/oozie to commons-collections4. If both of those efforts are successful then this package won't be needed, and imo that's the ideal path. jung is the most dependent package, and I'm close to porting it to commons-collections4. I hope to complete jung in the next few days. I was able to move jung and oozie to commons-collections4, so this package is no longer needed. Closing the review request awesome, thanks ! |