Bug 1061817

Summary: [RFE] Spice: use Application Menu and X-client-side close button in Gnome-shell for better integration and better use of screen real estate
Product: Red Hat Enterprise Linux 8 Reporter: David Jaša <djasa>
Component: virt-viewerAssignee: Default Assignee for SPICE Bugs <rh-spice-bugs>
Status: CLOSED WONTFIX QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: ---CC: aoconnor, berrange, dblechte, desktop-qa-list, dfediuck, dyuan, jjongsma, juzhou, lsurette, marcandre.lureau, mavital, mtessun, mzhan, spower, srevivo, tyan, tzheng, victortoso, xiaodwan
Target Milestone: rcKeywords: FutureFeature, Tracking
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-26 13:55:48 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Spice RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Jaša 2014-02-05 16:57:04 UTC
Description of problem:
virt-viewer/remote-viewer currently uses the same window layout as is typical for gnome2 applications: top bar drawn by window manager contains close (minimize, maximize) button(s) and the menu bar inside application window contains menu items. It would be nice to follow gnome3 design guidelines and use
  * application menu + menu under icons instead of current menu
  * close button within application window
These changes would help r-v better fit to gnome-shell environment but mainly: they would save few dozen pixels of vertical screen estate now used for menu and top-bar to actual guest display.

Version-Release number of selected component (if applicable):
virt-viewer-0.5.7-5.el7.x86_64

How reproducible:
always

Steps to Reproduce:
1. run remote-viewer in gnome-shell
2.
3.

Actual results:
remote-viewer has gnome2 feel

Expected results:
remote-viewer uses client-side action buttons and global application menu giving "gnome3" look & feel

Additional info:

Comment 1 Jonathon Jongsma 2014-07-18 15:01:37 UTC
I don't think this is really feasible as long as we are still maintaining GTK2 support. Once GTK2 support is dropped, we can look at this.

Comment 2 David Blechter 2014-08-04 11:36:07 UTC
keeping for future consideration, moving to 7.2 for now

Comment 3 Marc-Andre Lureau 2015-04-21 23:55:52 UTC
imho this is a rather cosmetic change, could be considered outside of rhel scope 
unlikely to happen in 7.2, moving

Comment 4 David Blechter 2015-09-03 08:47:09 UTC
moving to only RHEVM RFEs for PM to consider, if we want to match the look on all supported client platforms

Comment 5 Sandro Bonazzola 2017-12-20 13:59:36 UTC
oVirt 4.2.0 has been released on Dec 20th 2017. Please consider re-targeting this bug to next milestone

Comment 6 Yaniv Kaul 2018-06-14 08:23:26 UTC
4.2.2 has been released long time ago. Re-target?

Comment 8 Sandro Bonazzola 2019-03-12 12:52:27 UTC
4.3.1 has been released, please re-target this bug as soon as possible.

Comment 9 Martin Tessun 2019-03-22 19:19:41 UTC
Let's consider this cosmetic change for 4.4.
@David: Are you ok with delivering this in 4.4?

Comment 10 Victor Toso 2019-09-17 15:37:52 UTC
There was a good work in progress on this in 2017 and before, around GTK3 integration in virt-viewer.
Code is here [0], I'll give it a try on integrating with upstream next cycle.

[0] https://github.com/etrunko/virt-viewer/commits/dialogs