Bug 1062655

Description of problem:
When I create an app and specify the template with --from-code <url>, the URL specified is for cloning the app's git repository at creation time. If cloning fails for some reason, the error message should be clear. It's not.

Version-Release number of selected component (if applicable):
As far as I can tell, for OSE 1.2 and 2.0.0, the message was correct. I suspect with 2.0.1 or 2.0.2, that changed.

Steps to Reproduce:
1. Against a recent OSE 2.0 install, do "rhc app create foo php --from-code http://example.com/foo.git"

Actual results:
Unable to complete the requested operation due to: An invalid exit code (131) was returned from the server broker.ose203.example.com.  This indicates an unexpected problem during the execution of your request..

Expected results:
Source code repository could not be cloned: 'http://example.com/foo.git'. Please verify the repository is correct and contact support.

Additional info:
Basically, it's a node execution error, and there's not a lot about what actually went wrong in the node logs, so this would be kind of hard to track down. You do get something like this in /var/log/openshift/node/platform-trace.log:

February 07 08:39:52 INFO oo_spawn running \
set -xe;
git clone --bare --no-hardlinks 'http://example.com/foo.git' foo.git;
GIT_DIR=./foo.git git config core.logAllRefUpdates true;

GIT_DIR=./foo.git git repack;
: {:unsetenv_others=>false, :close_others=>true, :in=>"/dev/null", :chdir=>"/var/lib/openshift/52f4fe3d3eefa9d3870000f4/git", :out=>#<IO:fd 10>, :err=>#<IO:fd 8>}
February 07 08:39:52 INFO oo_spawn buffer(6/) + git clone --bare --no-hardlinks http://example.com/foo.git foo.git

February 07 08:39:52 INFO oo_spawn buffer(9/) Initialized empty Git repository in /var/lib/openshift/52f4fe3d3eefa9d3870000f4/git/foo.git/

February 07 08:39:52 INFO oo_spawn buffer(6/) fatal: http://example.com/foo.git/info/refs not found: did you run git update-server-info on the server?