Bug 106298

Summary: php bad source code
Product: [Retired] Red Hat Linux Reporter: d.binderman
Component: phpAssignee: Joe Orton <jorton>
Status: CLOSED CURRENTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 9   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-01-24 12:02:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description d.binderman 2003-10-05 08:50:46 UTC
Description of problem:

Hello there,

I just tried to compile package php-4.2.2-17 from Redhat 9.0
with compiler flag -Wall.

The compiler said

/usr/src/redhat/BUILD/php-4.2.2/ext/imap/php_imap.c:2291: warning: operation on
`outp' may be undefined
/usr/src/redhat/BUILD/php-4.2.2/ext/imap/php_imap.c:2297: warning: operation on
`outp' may be undefined
/usr/src/redhat/BUILD/php-4.2.2/ext/imap/php_imap.c:2401: warning: operation on
`outp' may be undefined
/usr/src/redhat/BUILD/php-4.2.2/ext/imap/php_imap.c:2414: warning: operation on
`outp' may be undefined
/usr/src/redhat/BUILD/php-4.2.2/ext/imap/php_imap.c:2419: warning: operation on
`outp' may be undefined

As an example, consider the first piece of source code

*outp++ |= outp[1] >> 4;

You would be much better off with 

*outp |= outp[1] >> 4;
++outp;





Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
    
Actual results:


Expected results:


Additional info:

Comment 1 Joe Orton 2004-01-24 12:02:40 UTC
This is fixed in the current sources for Fedora Core 1, thanks for the
report.