Bug 1063048
| Summary: | Review Request: rubygem-eventmachine_httpserver - EventMachine HTTP Server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nitesh Narayan Lal <niteshnarayan> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mmorsi, msuchy, niteshnarayan, niteshnarayanlalleo, package-review |
| Target Milestone: | --- | Flags: | niteshnarayanlalleo:
needinfo+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-02 16:02:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nitesh Narayan Lal
2014-02-09 18:06:54 UTC
Hey Nitesh some comments:
- Spec file name should be 'rubygem-eventmachine_httpserver.spec'
- %description should be a bit more descriptive than "Simple http server." Unfortunately there is not alot by ways of documentation in this gem but perhaps you could just write a sentence or two describing what it is, how it relates to event machine and stuff like "faster than other web servers" "non-rfc-strict parser" etc (just wouldn't reference other web servers like "thin" or "mongrel" specifically)
- The rspec command should be "rspec -Ilib spec"
- The %{gem_instdir}/eventmachine_httpserver.gemspec.* files should be rm'd or excluded
- The test dir and Rakefile should be rm'd, excluded, or marked as %doc
- This package is missing a LICENSE file, it should be included
Ping? Any progress? Nitesh conveyed to me via email that he is no longer interested in working on this. Sorry for the belated response |