Bug 1063541

Summary:	Python test in configure script pollutes CFLAGS
Product:	[Community] GlusterFS	Reporter:	Luis Pabón <lpabon>
Component:	build	Assignee:	Luis Pabón <lpabon>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs, madam
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-11 08:27:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Luis Pabón 2014-02-11 00:24:47 UTC

Description of problem:
When the configure script runs, it executes a test to obtain the build flags to build glupy.  The python flags are appended to the CFLAGS used for the regular glusterFS build.  CFLAGS had both -O2 and -O0, and even when the switch '--enable-debug' is given to configure, -NDEBUG is set by the python test.

The python flags should only be used when compiling glupy and not the rest of the glusterfs system.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-02-11 00:31:54 UTC

REVIEW: http://review.gluster.org/6957 (build: CFLAGS was being polluted by python flags) posted (#1) for review on master by Luis Pabon (lpabon)

Comment 2 Anand Avati 2014-02-11 00:37:27 UTC

REVIEW: http://review.gluster.org/6957 (build: CFLAGS was being polluted by python flags) posted (#2) for review on master by Luis Pabon (lpabon)

Comment 3 Anand Avati 2014-02-11 14:22:49 UTC

REVIEW: http://review.gluster.org/6957 (build: CFLAGS was being polluted by python flags) posted (#3) for review on master by Luis Pabon (lpabon)

Comment 4 Anand Avati 2014-02-12 21:30:39 UTC

COMMIT: http://review.gluster.org/6957 committed in master by Anand Avati (avati) 
------
commit 58d7ef2f7628744db4c7bf8bf5735671e023f1d7
Author: Luis Pabon <lpabon>
Date:   Sun Feb 9 21:57:45 2014 -0500

    build: CFLAGS was being polluted by python flags
    
    The CFLAGS were being polluted by the python test for glupy. The
    test also sets CFLAGS -NDEBUG even when passing --enable-debug to
    configure.
    
    To fix it, the patch now saves the necessary python flags into
    new makefile flags which can now be used by the glupy Makefile.am.
    
    BUG: 1063541
    Change-Id: I8546a64b8ad4fe9318a97fb6a2f0c36087be1b29
    Signed-off-by: Luis Pabon <lpabon>
    Reviewed-on: http://review.gluster.org/6957
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Harshavardhana <harsha>
    Tested-by: Harshavardhana <harsha>

Comment 5 Niels de Vos 2014-11-11 08:27:45 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users