Bug 1064096
| Summary: | The old Python Translator code (not Glupy) should be removed | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Justin Clift <jclift> |
| Component: | unclassified | Assignee: | Justin Clift <jclift> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.5.0 | CC: | gluster-bugs, kwade, ndevos |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.5.1beta | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-24 11:03:26 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1071800 | ||
REVIEW: http://review.gluster.org/6980 (Removed the old and unused non-Glupy Python bindings code) posted (#1) for review on master by Justin Clift (jclift) COMMIT: http://review.gluster.org/6980 committed in master by Anand Avati (avati) ------ commit 0a8abcc5d0b727746a2ac6c0d5729700bfea742b Author: Justin Clift <jclift> Date: Wed Feb 12 04:17:29 2014 +0000 Removed the old and unused non-Glupy Python bindings code BUG: 1064096 Change-Id: Ifd34f46f0f0b45bbc27d35953e6ecbca36753886 Signed-off-by: Justin Clift <jclift> Reviewed-on: http://review.gluster.org/6980 Reviewed-by: Jeff Darcy <jdarcy> We do not seem to have a backport to the release-3.5 branch yet? Moving t oglusterfs-3.5.1 and setting to ASSIGNED. REVIEW: http://review.gluster.org/7731 (Removed the old and unused non-Glupy Python bindings code) posted (#1) for review on release-3.5 by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/7731 committed in release-3.5 by Niels de Vos (ndevos) ------ commit 4fbbbcf72a0de6df19b14f2af9da653c6190dfe2 Author: Niels de Vos <ndevos> Date: Sun May 11 00:42:06 2014 -0300 Removed the old and unused non-Glupy Python bindings code Cherry picked from commit 0a8abcc5d0b727746a2ac6c0d5729700bfea742b: > BUG: 1064096 > Change-Id: Ifd34f46f0f0b45bbc27d35953e6ecbca36753886 > Signed-off-by: Justin Clift <jclift> > Reviewed-on: http://review.gluster.org/6980 > Reviewed-by: Jeff Darcy <jdarcy> Change-Id: I330dca1d53cb85ffc9ee823afa6bca056f34c824 BUG: 1064096 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/7731 Tested-by: Gluster Build System <jenkins.com> The first (and last?) Beta for GlusterFS 3.5.1 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.1beta release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-May/040377.html [2] http://supercolony.gluster.org/pipermail/gluster-users/ This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.1, please reopen this bug report. glusterfs-3.5.1 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-June/040723.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |
Description of problem: In Gluster's git repo (3.5 dev master) we have two competing approaches to writing translators in Python: * xlators/features/glupy * xlators/bindings/python The "Glupy" one should probably be kept, as it's more complete, so the older, less complete "python" one should be removed. Version-Release number of selected component (if applicable): Upstream GlusterFS git repo, master branch, as of Wed 12 Feb. Additional info: Emailed Jeff Darcy about this, and his response is: On 12/02/2014, at 1:52 AM, Jeff Darcy wrote: > Trying to fix a bug in Glupy, and noticed there seems to be two > different approaches for writing translators in Python: > > * xlators/bindings/python/src This seems to be a very old (almost exactly four years old) and very incomplete attempt at a Python translator framework. It's not built, probably couldn't be built, and IMO should be deleted. > * xlators/features/glupy/src This is the version that I wrote (and wrote about) which was subsequently taken over by others. AFAIK it's functional and current. So pretty sure the old code can be nuked.