Bug 1064435

Summary: sssd spec suffers from Double separator '-' error
Product: [Fedora] Fedora Reporter: Brent Baude <bbaude>
Component: sssdAssignee: Jakub Hrozek <jhrozek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: abokovoy, dhorak, jhrozek, lslebodn, pbrezina, sbose, sgallagh, ssorce
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-13 09:12:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
a patch against rawhide none

Description Brent Baude 2014-02-12 15:52:30 UTC
the rawhide sssd spec suffers from the Double separator '-' error being enforced by more recent RPM versions.

error: line 85: Double separator '-' in: samba4-4.0.0-59beta2: BuildRequires: samba4-devel >= samba4-4.0.0-59beta2
error: query of specfile /ppc64le/stage3/fedora-git/sssd/sssd.spec failed, can't parse

A simple fix is provided below.

[baude@localhost sssd]$ git diff
diff --git a/sssd.spec b/sssd.spec
index c7259f8..c2241b0 100644
--- a/sssd.spec
+++ b/sssd.spec
@@ -82,7 +82,7 @@ BuildRequires: pkgconfig
 BuildRequires: glib2-devel
 BuildRequires: diffstat
 BuildRequires: findutils
-BuildRequires: samba4-devel >= samba4-4.0.0-59beta2
+BuildRequires: samba4-devel >= 4.0.0-59beta2
 BuildRequires: selinux-policy-targeted
 %ifarch %{ix86} x86_64 %{arm}
 BuildRequires: libcmocka-devel

Comment 1 Jakub Hrozek 2014-02-12 16:11:56 UTC
Upstream ticket:
https://fedorahosted.org/sssd/ticket/2241

Comment 2 Jakub Hrozek 2014-02-12 22:17:30 UTC
Lukas, given you closed the upstream ticket, can you ack the Fedora patch?

Comment 3 Jakub Hrozek 2014-02-12 22:18:21 UTC
Created attachment 862562 [details]
a patch against rawhide

Comment 4 Jakub Hrozek 2014-02-12 22:25:39 UTC
Here is a scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6523359

Comment 5 Lukas Slebodnik 2014-02-13 07:53:31 UTC
Other packages use only version without name. Scratch build finished successfully.

ACK

BuildRequires: libdhash-devel >= 0.4.2
BuildRequires: krb5-devel >= 1.10
Requires: libini_config >= 1.0.0.1


BTW: Will sssd package in rawhide contain following patch?
"FAST: when parsing krb5_child response, make sure to not miss"

Because I was able to find build sssd-1.11.3-2 only for fedora 20.
http://koji.fedoraproject.org/koji/packageinfo?packageID=7925

Comment 6 Jakub Hrozek 2014-02-13 09:12:59 UTC
(In reply to Lukas Slebodnik from comment #5)
> Other packages use only version without name. Scratch build finished
> successfully.
> 
> ACK
> 

Thanks, built in master.

> BuildRequires: libdhash-devel >= 0.4.2
> BuildRequires: krb5-devel >= 1.10
> Requires: libini_config >= 1.0.0.1
> 
> 
> BTW: Will sssd package in rawhide contain following patch?
> "FAST: when parsing krb5_child response, make sure to not miss"
> 
> Because I was able to find build sssd-1.11.3-2 only for fedora 20.
> http://koji.fedoraproject.org/koji/packageinfo?packageID=7925

It's already in master/rawhide, see commit 
9c2fb314df3330966a6f48ad19f6a2edf9543423