Bug 1064693

Summary:	Injections to revision history topic result in validation error
Product:	[Community] PressGang CCMS	Reporter:	Matthew Casperson <mcaspers>
Component:	CCMS-Core	Assignee:	Lee Newson <lnewson>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.3	CC:	cbredesen, lnewson
Target Milestone:	---
Target Release:	1.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-23 23:43:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Matthew Casperson 2014-02-13 05:57:03 UTC

See spec 22688 on the dev server. Topic 30505 has an injection to topic 28948, which is the revision history topic. This generates an error:

ERROR: Topic has referenced Topic/Level(s) 28948 in a custom injection point that was not included this book.

Comment 3 Lee Newson 2014-02-13 07:22:14 UTC

Fixed in 1.4-SNAPSHOT build 201402131720

Fixed the injection resolution to look up Meta Data topics as well. Also configured the builder to add ids for all current metadata topic types.

Comment 6 Matthew Casperson 2014-02-13 20:14:04 UTC

Confirmed the fix.

Comment 7 Lee Newson 2014-02-14 04:32:04 UTC

*** Bug 1065157 has been marked as a duplicate of this bug. ***

Comment 8 Lee Newson 2014-02-14 04:32:48 UTC

Moving back to assigned as the injection doesn't work for invalid revision histories. See BZ#1065157

Comment 9 Lee Newson 2014-02-14 04:48:41 UTC

Moving back to VERIFIED as we cannot reproduce it, so it's possible an older temporary file was used.

Comment 10 Lee Newson 2014-02-14 06:59:46 UTC

You can replicate the issue above by failing the Fixed URL pass, so moving this back to ASSIGNED.

Comment 11 Lee Newson 2014-02-14 07:02:55 UTC

Fixed in 1.4-SNAPSHOT build 201402141700

If a networking error occurred during any stage of the Fixed URL pass then the entire process would fail and wouldn't be attempted again. This also meant that any static Fixed URLs (ie Revision History, Author Group, etc...) weren't being set.

There was also the issue of the Revision History always attempting to use the static human readable URL, when it should have been using the same mechanism as the rest of the topics.

Comment 13 Matthew Casperson 2014-02-17 03:35:26 UTC

I had a build fail with the issue described in https://bugzilla.redhat.com/show_bug.cgi?id=1065586, but the xrefs all still resolved, even to the revision history.