Bug 1065576
| Summary: | Add additional patches to urllib2_kerberos | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matěj Cepl <mcepl> | ||||||
| Component: | python-urllib2_kerberos | Assignee: | Tomas Dabašinskas <tdabasin> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | ben.dylan.jones, mcepl, rmonk, tdabasin | ||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | python-urllib2_kerberos-0.1.6-14.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-09-27 09:50:55 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 578711 | ||||||||
| Attachments: |
|
||||||||
Hi Matěj, looks good please attach srpm and I'll rebuild the package, alternatevly please request access to modify the package by clicking "Add myself to package" here https://admin.fedoraproject.org/pkgdb/acls/name/python-urllib2_kerberos http://mcepl.fedorapeople.org/tmp/python-urllib2_kerberos-0.1.6-10.fc21.src.rpm check the release number, changelog, etc. (In reply to Tomas Dabašinskas from comment #1) > Hi Matěj, looks good please attach srpm and I'll rebuild the package, > alternatevly please request access to modify the package by clicking "Add > myself to package" here > https://admin.fedoraproject.org/pkgdb/acls/name/python-urllib2_kerberos BTW, I am a provenpackager, so I can build the package without getting explicitly into the package. However, I don't want to do anything behind your back. Matěj, please feel free to add the patches to urllib2_kerberos python-urllib2_kerberos-0.1.6-11.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-11.fc20 python-urllib2_kerberos-0.1.6-11.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-11.fc19 python-urllib2_kerberos-0.1.6-11.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-11.el6 python-urllib2_kerberos-0.1.6-11.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. python-urllib2_kerberos-0.1.6-11.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. python-urllib2_kerberos-0.1.6-11.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. Hi, this seems to not work with python 2.6, and therefore on EPEL 6. Specifically line 36 in negotiate_value() has:
log.debug('authreqs = {}'.format(authreqs))
In my case, and I'd have thought the normal case where "authreqs" has the value: ['Negotiate'] then we get this error from the format:
ipdb> 'authreqs = {}'.format(authreqs)
*** ValueError: zero length field name in format
It works fine for python 2.7:
In [1]: authreqs = ['Negotiate']
In [2]: 'authreqs = {}'.format(authreqs)
Out[2]: "authreqs = ['Negotiate']"
Reopening per comment 12 python-urllib2_kerberos-0.1.6-13.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-13.el6 python-urllib2_kerberos-0.1.6-13.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-13.fc19 python-urllib2_kerberos-0.1.6-13.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-13.fc20 python-urllib2_kerberos-0.1.6-13.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-13.fc21 python-urllib2_kerberos-0.1.6-13.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-13.el7 Created attachment 938499 [details] [PATCH] Set default logging to INFO, not DEBUG, and fix python .format() code for Python 2.6 compatiblity It looks like the add_logging patch sets the default logging level to DEBUG (not ideal) and the log format lines are not Python 2.6 compatible. I've attached a patch that seems to solve both issues, against http://pkgs.fedoraproject.org/cgit/python-urllib2_kerberos.git/tree/ python-urllib2_kerberos-0.1.6-13.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. python-urllib2_kerberos-0.1.6-13.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. python-urllib2_kerberos-0.1.6-13.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. python-urllib2_kerberos-0.1.6-14.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. python-urllib2_kerberos-0.1.6-14.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 863543 [details] suggested patch Description of problem: Upstream seems to be a bit dead so I have collected all patches to urllib2_kerberos I could find Version-Release number of selected component (if applicable): python-urllib2_kerberos-0.1.6-9.fc21.noarch