Bug 1065854

Summary: PreparedStatement and ResultSet objects not closed correctly from SQL JSTL tags
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: James Livingston <jlivings>
Component: unspecifiedAssignee: Shelly McGowan <smcgowan>
Status: CLOSED CURRENTRELEASE QA Contact: Jan Stefl <jstefl>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: joallen, kkhan, lfuka, pslavice, smcgowan
Target Milestone: DR1   
Target Release: EAP 6.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-19 12:42:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1067151, 1079497    
Bug Blocks:    

Description James Livingston 2014-02-17 06:50:40 UTC
When using the JSTL SQL tags, PreparedStatement and ResultSet objects are not closed correct when some errors occur.

This was fixed in the upstream Apache Taglib code (https://issues.apache.org/bugzilla/show_bug.cgi?id=17388) but the fix was not backported to our fork.

Comment 1 JBoss JIRA Server 2014-02-19 19:23:47 UTC
Shelly McGowan <smcgowan> updated the status of jira JBEE-147 to Resolved

Comment 3 Shelly McGowan 2014-02-19 20:06:35 UTC
Note this change was reviewed by rmaucher, passes the JSTL TCK tests and the EE 6 signature tests.

Comment 5 Martin Velas 2014-09-18 14:38:32 UTC
I have verified  that the patch http://svn.apache.org/viewvc/jakarta/taglibs/proper/standard/trunk/src/org/apache/taglibs/standard/tag/common/sql/QueryTagSupport.java?view=diff&r1=499149&r2=499150&pathrev=499150 was used in jboss-jstl-api_1.2_spec for both the version 1.0.5.Final and 1.0.6.Final (used in EAP 6.3.0.GA).

This change was also verified by JSTL TCK tests and the EE 6 signature tests - see above.