Bug 1066510

Summary: Simulation results: If sum of probability for XOR is greater than 100% then simulation engine executes more instances of the process.
Product: [Retired] JBoss BPMS Platform 6 Reporter: Sona Mala <smala>
Component: jBPM DesignerAssignee: Maciej Swiderski <mswiders>
Status: CLOSED CURRENTRELEASE QA Contact: Sona Mala <smala>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0.1CC: kverlaen, lpetrovi, rrajasek
Target Milestone: ER2   
Target Release: 6.0.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:04:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
BPMN2 process
none
Screen shot - simulation results none

Description Sona Mala 2014-02-18 14:51:20 UTC 
Created attachment 864594 [details]
BPMN2 process

Description of problem:
See related issue

Version-Release number of selected component (if applicable):
6.0.1 ER1 BPMS


Steps to Reproduce:
1. Import attached process
2. Simulate (number of instances is 10)
3. See results

Actual results:
See attached screen shot. Task A was run 20 times, but user required 10 times.


Expected results:
Simulation engine should stop with error message.


Additional info:
I suggest change condition "if (provider != null && probabilitySummary < 1)" should be changed to "if (provider != null && probabilitySummary != 1)" at line #81 in file https://github.com/droolsjbpm/droolsjbpm-integration/blob/83da4b927cfc0711265c92db05b5f87a4a115215/jbpm-simulation/src/main/java/org/jbpm/simulation/converter/SimulationFilterPathFormatConverter.java
Comment 1 Sona Mala 2014-02-18 14:52:42 UTC 
Created attachment 864595 [details]
Screen shot - simulation results
Comment 2 Maciej Swiderski 2014-02-19 19:58:52 UTC 
fixed to cover both upper and lower probability errors

droolsjbpm-integration
master:
https://github.com/droolsjbpm/droolsjbpm-integration/commit/423f4afb7eebedf8460f4b135dd559c102e9eb92

6.0.x:
https://github.com/droolsjbpm/droolsjbpm-integration/commit/e466a62631236283c8b5f8044833b605a8aea640
Comment 3 Sona Mala 2014-03-11 13:06:36 UTC 
In 6.0.1 ER2, I verify that the simulation engine fails (with correct alert) if sum of probabilities of all outgoing sequence flows from XOR gateways is not equals 100 %.