Bug 1066852
| Summary: | Review Request: perl-Encode-DoubleEncodedUTF8 - Fix double encoded UTF-8 bytes to the correct one | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Dick <ddick> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Encode-DoubleEncodedUTF8-0.05-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-03-10 06:47:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Dick
2014-02-19 08:50:00 UTC
Missing BRs: perl(Encode::Encoding), used at lib/Encode/DoubleEncodedUTF8.pm:4 perl(ExtUtils::MM_Unix), required at inc/Module/Install/Metadata.pm:317,326 perl(File::Spec), used at inc/Module/Install/Can.pm:6 Net::FTP and Pod::Escapes are definitely not required for build. This most likely applies to many of the optional dependencies in inc/Spiffy.pm and inc/Test/*. I suggest going through that and removing what you don't really need to keep the package simple. Less dependencies mean less pain during bootstrap rebuilds :) I've had an attempt at filtering out the non-required deps. If you've got any other suggestions, more than happy to apply them. Thanks again for all your help! The Spec and SRPM files have been updated This is ready for approval. Hmm, the SPEC link points to the same, old, unchanged file...? That's embarrassing. I've actually uploaded the files now. Sorry. No worries :) I see you've dropped Pod::Text. That one is required in readme_from() which is called in Makefile.PL. Please, put it back before pushing. I'm going to approve this now. New Package SCM Request ======================= Package Name: perl-Encode-DoubleEncodedUTF8 Short Description: Fix double encoded UTF-8 bytes to the correct one Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig Git done (by process-git-requests). perl-Encode-DoubleEncodedUTF8-0.05-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Encode-DoubleEncodedUTF8-0.05-1.el6 perl-Encode-DoubleEncodedUTF8-0.05-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Encode-DoubleEncodedUTF8-0.05-1.fc20 perl-Encode-DoubleEncodedUTF8-0.05-1.el6 has been pushed to the Fedora EPEL 6 testing repository. perl-Encode-DoubleEncodedUTF8-0.05-1.fc20 has been pushed to the Fedora 20 stable repository. perl-Encode-DoubleEncodedUTF8-0.05-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |