Bug 1067297

Description of problem:

As of now we modify hookscripts as below during upgrade of GlusterFS RPMs because we need use the new hook scripts to be used by Gluster and not the old ones.

1. The first letter 'S' is modified to be a 'K'
2. Appending .rpmsave to the file
e.g: Hook script "S30samba-set.sh" will be modified to "K30samba-set.sh.rpmsave"during a rpm upgrade

We preserve the old hook scripts just to make sure Admin/user is not loosing any changes in-case he has done some changes to the hook scripts which is I think standard RPM procedure.

But this step to preserve old hook scripts overdo it and during multiple upgrades, all the old hook scripts were saved and the hooks scripts look cluttered (as below). Which is not desirable.
 
K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/set/post/S30samba-set.sh
/var/lib/glusterd/hooks/1/start/post/S30samba-start.sh

Version-Release number of selected component (if applicable):

glusterfs-3.4.0.59rhs-1.el6rhs.x86_64

How reproducible:

Always

Steps to Reproduce:
1.
2.
3.

Actual results:

A RHS system which has gone though multiple upgrades, the hooks script look very cluttered.

Expected results:

It should be cleaner than current implementation.

Additional info:

Here is an example of how hook scripts look for a system gone through multiple upgrades.

find /var/lib/glusterd/hooks -type f
/var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/set/post/S30samba-set.sh
/var/lib/glusterd/hooks/1/start/post/S30samba-start.sh
/var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave
/var/lib/glusterd/hooks/1/start/post/S29CTDBsetup.sh
/var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/gsync-create/post/S56glusterd-geo-rep-create-post.sh
/var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave
/var/lib/glusterd/hooks/1/stop/pre/S29CTDB-teardown.sh
/var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/stop/pre/S30samba-stop.sh
/var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/add-brick/post/disabled-quota-root-xattr-heal.sh.rpmsave
/var/lib/glusterd/hooks/1/add-brick/post/disabled-quota-root-xattr-heal.sh.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/add-brick/post/disabled-quota-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/add-brick/post/disabled-quota-root-xattr-heal.sh
/var/lib/glusterd/hooks/1/add-brick/pre/S28Quota-enable-root-xattr-heal.sh
/var/lib/glusterd/hooks/1/add-brick/pre/K28Quota-enable-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave.rpmsave
/var/lib/glusterd/hooks/1/add-brick/pre/K28Quota-enable-root-xattr-heal.sh.rpmsave.rpmsave