Bug 1067344

Summary:	TryBackToAllSnapshotsOfVm threw NullPointerException during snapshot-preview because of random disk attached to VM
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Allon Mureinik <amureini>
Component:	ovirt-engine	Assignee:	Liron Aravot <laravot>
Status:	CLOSED ERRATA	QA Contact:	Aharon Canan <acanan>
Severity:	high	Docs Contact:
Priority:	urgent
Version:	3.2.0	CC:	abaron, acathrow, amureini, audgiri, dornelas, ebenahar, fsimonce, hchiramm, iheim, jbiddle, laravot, lnatapov, lpeer, mkalinin, Rhev-m-bugs, scohen, tnisan, yeylon
Target Milestone:	---	Keywords:	ZStream
Target Release:	3.2.6
Hardware:	All
OS:	Linux
Whiteboard:	storage
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Previously the snapshot manager attempted to remove disks that are not part of a snapshot. Now, if the device is not a disk known by the engine, it is not removed, similar to the behavior of non-snapshot disks.	Story Points:	---
Clone Of:	1032807	Environment:
Last Closed:	2014-03-05 14:17:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1032807
Bug Blocks:	1044030

Comment 2 Allon Mureinik 2014-02-24 19:04:19 UTC

Jodi, we need the same doctext as bug 1032807 for 3.2.6's release note:

"Previously the snapshot manager attempted to remove disks that are not part of a snapshot. Now, if the device is not a disk known by the engine, it is not removed, similar to the behavior of non-snapshot disks."

Is the required-doc-text flag enough, or do we need something else for the doc team's process?

Thanks!

Comment 4 Jodi Biddle 2014-02-25 23:24:49 UTC

(In reply to Allon Mureinik from comment #2)
> Jodi, we need the same doctext as bug 1032807 for 3.2.6's release note:
> 
> "Previously the snapshot manager attempted to remove disks that are not part
> of a snapshot. Now, if the device is not a disk known by the engine, it is
> not removed, similar to the behavior of non-snapshot disks."
> 
> Is the required-doc-text flag enough, or do we need something else for the
> doc team's process?
> 
> Thanks!

Copying the doc text and setting the flag is enough for errata, but if you want this to go into manager release notes you need to make sure the doc text field is appropriately set to "release note" so that our filters catch it. Thanks for double-checking :)

Comment 5 Leonid Natapov 2014-03-03 13:36:58 UTC

tested on 3.2.6-0.50.el6ev.

VM with IDE disk created. Hook before_vm_start  adds disk that is not managed by RHEVM. Snapshot created with and without hook. Can be previewed without errors.

Comment 7 errata-xmlrpc 2014-03-05 14:17:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0251.html