Bug 1068029

Summary:	dogtag-pki-theme: Switch to java-headless (build)requires
Product:	[Fedora] Fedora	Reporter:	Stanislav Ochotnicky <sochotni>
Component:	dogtag-pki-theme	Assignee:	Matthew Harmsen <mharmsen>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	22	CC:	alee, dennis, dpal, edewata, gsterlin, jpazdziora, mharmsen, mkosek, sochotni
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-02 17:54:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1067528

Description Stanislav Ochotnicky 2014-02-21 12:31:40 UTC

dogtag-pki-theme or one of its subpackages currently Requires and/or BuildRequires
java. OpenJDK package has been split and most packages should now Require
package 'java-headless' instead. Requires and BuildRequires on java-devel remain
unchanged.

Few exceptions where packages can not use java-headless but must keep using
full java package.
 * software using Java awt subsystem
 * software using Java sound subsystem

Your options:
1. Leave this bug untouched and after March 17th 2014 an automated tool will
   migrate this package to java-headless and run a rebuild in Fedora Rawhide.
2. Change bug to 'Assigned' if you plan to review and migrate to java-headless
   manually. Automated tool will not touch bugs that are not in NEW state.

See tracking bug #1067528 or Headless Java change proposal[1] and Java Packaging
guidelines[2] for more details about this change.

If you have more questions about this change feel free to ask on java-devel
mailing list[3] or #fedora-java Freenode IRC channel (mostly 9:00-18:00 CET).


[1] https://fedoraproject.org/wiki/Changes/HeadlessJava
[2] https://fedoraproject.org/wiki/Packaging:Java\#BuildRequires_and_Requires
[3] http://lists.fedoraproject.org/pipermail/java-devel/

Comment 1 Jan Pazdziora (Red Hat) 2014-05-30 11:19:14 UTC

Was this done? List at http://koji.fedoraproject.org/koji/packageinfo?packageID=11475 does not show any rawhide (fc21) builds this year ...

Comment 2 Jan Pazdziora (Red Hat) 2014-07-14 11:58:23 UTC

Does dogtag-pki-console-theme require java or could it use java-headless?

Comment 3 Matthew Harmsen 2014-07-14 21:48:28 UTC

(In reply to Jan Pazdziora from comment #2)
> Does dogtag-pki-console-theme require java or could it use java-headless?

Although I have not tested it, the 'dogtag-pki-console-theme' package should be able to simply utilize 'java-headless', as although it contains a 'jar' file, the 'jar' file merely consists of the following 'property' and 'gif' files:

unzip -l /usr/share/java/pki/pki-console-theme.jar
Archive:  /usr/share/java/pki/pki-console-theme.jar
  Length      Date    Time    Name
---------  ---------- -----   ----
       68  01-01-1980 00:00   META-INF/MANIFEST.MF
   306232  01-01-1980 00:00   CMSAdminRS.properties
        0  01-01-1980 00:00   META-INF/
        0  01-01-1980 00:00   com/
        0  01-01-1980 00:00   com/netscape/
        0  01-01-1980 00:00   com/netscape/admin/
        0  01-01-1980 00:00   com/netscape/admin/certsrv/
        0  01-01-1980 00:00   com/netscape/admin/certsrv/theme/
     5565  01-01-1980 00:00   com/netscape/admin/certsrv/theme/certmgmt.gif
        0  01-01-1980 00:00   com/netscape/management/
        0  01-01-1980 00:00   com/netscape/management/client/
        0  01-01-1980 00:00   com/netscape/management/client/theme/
        0  01-01-1980 00:00   com/netscape/management/client/theme/images/
     5565  01-01-1980 00:00   com/netscape/management/client/theme/images/ConsoleBanner.gif
    20908  01-01-1980 00:00   com/netscape/management/client/theme/images/login.gif
      994  01-01-1980 00:00   com/netscape/management/client/theme/images/logo16.gif
     1458  01-01-1980 00:00   com/netscape/management/client/theme/images/logo32.gif
     1302  01-01-1980 00:00   com/netscape/management/client/theme/theme.properties
---------                     -------
   342092                     18 files

The base 'pki-console' package still requires 'java', however, since it consists of the PKI console which is written in Java AWT/Swing.

Comment 4 Jan Pazdziora (Red Hat) 2014-07-16 12:48:19 UTC

(In reply to Matthew Harmsen from comment #3)
> (In reply to Jan Pazdziora from comment #2)
> > Does dogtag-pki-console-theme require java or could it use java-headless?
> 
> Although I have not tested it, the 'dogtag-pki-console-theme' package should
> be able to simply utilize 'java-headless', as although it contains a 'jar'

Great.

> The base 'pki-console' package still requires 'java', however, since it
> consists of the PKI console which is written in Java AWT/Swing.

That shouldn't be a problem -- pki-console is not among freeipa-server dependencies.

Comment 5 Matthew Harmsen 2014-07-16 18:24:09 UTC

(In reply to Jan Pazdziora from comment #4)
> (In reply to Matthew Harmsen from comment #3)
> > (In reply to Jan Pazdziora from comment #2)
> > > Does dogtag-pki-console-theme require java or could it use java-headless?
> > 
> > Although I have not tested it, the 'dogtag-pki-console-theme' package should
> > be able to simply utilize 'java-headless', as although it contains a 'jar'
> 
> Great.
> 
> > The base 'pki-console' package still requires 'java', however, since it
> > consists of the PKI console which is written in Java AWT/Swing.
> 
> That shouldn't be a problem -- pki-console is not among freeipa-server
> dependencies.

The 'dogtag-pki-theme' SRPM contains the 'dogtag-pki-console-theme' and 'dogtag-pki-server-theme' RPMS.

Actually, the 'dogtag-pki-console-theme' RPM should also not be among the freeipa-server dependencies, as this 'dogtag' variant of 'pki-console-theme' is only utilized by 'pki-console'.

Additionally, the 'dogtag-pki-server-theme' RPM only contains 'dogtag' images, css, etc. as used by the browser GUI which may only be needed by standalone Dogtag CS (I believe that the original CS dependency which required a 'theme' package has long since been removed).

Comment 6 Endi Sukma Dewata 2014-07-16 19:00:26 UTC

The theme packages probably shouldn't require java/java-headless/java-devel at run time. They probably only need java-devel at build time to package the theme files into a jar file. The Java runtime will only be needed by pki-console to load the jar file and run the Java GUI application.

Comment 7 Martin Kosek 2014-07-23 14:39:32 UTC

(In reply to Matthew Harmsen from comment #5)
...
> Actually, the 'dogtag-pki-console-theme' RPM should also not be among the
> freeipa-server dependencies, as this 'dogtag' variant of 'pki-console-theme'
> is only utilized by 'pki-console'.

Good point. I submitted a patch to FreeIPA to remove this dependency:

http://www.redhat.com/archives/freeipa-devel/2014-July/msg00337.html

Comment 8 Martin Kosek 2014-07-24 11:59:25 UTC

The patch was accepted and will be part of FreeIPA 4.1+.

Comment 9 Jaroslav Reznik 2015-03-03 15:30:39 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 10 Jan Pazdziora (Red Hat) 2015-11-16 10:09:14 UTC

(In reply to Martin Kosek from comment #8)
> The patch was accepted and will be part of FreeIPA 4.1+.

FreeIPA 4.1 was released some time ago. What is the correct status of this bugzilla?

Comment 11 Jan Pazdziora (Red Hat) 2015-11-23 07:31:04 UTC

(In reply to Martin Kosek from comment #8)
> The patch was accepted and will be part of FreeIPA 4.1+.

FreeIPA 4.1 was released some time ago. What is the correct status of this bugzilla?

Comment 12 Martin Kosek 2015-11-23 07:56:20 UTC

FreeIPA 4.1+ does not pull the package automatically since 4.1, as indicated:

$ git log -1 1026a6387cd392994ec996db53141d16dfcbee29
commit 1026a6387cd392994ec996db53141d16dfcbee29
Author: Martin Kosek <mkosek>
Date:   Wed Jul 23 16:35:13 2014 +0200

    Do not require dogtag-pki-server-theme
    
    Theme package is contains resources for PKI web interface. This interface
    is not needed by FreeIPA as it rather utilizes it's API. As recommended in
    https://bugzilla.redhat.com/show_bug.cgi?id=1068029#c5, remove this hard
    dependency.
    
    Reviewed-By: Alexander Bokovoy <abokovoy>

$ git tag --contains 1026a6387cd392994ec996db53141d16dfcbee29
alpha_1-4-1-0
alpha_1-4-2-0
release-4-1-0
release-4-1-1
release-4-1-2
release-4-1-3
release-4-1-4
release-4-2-0
release-4-2-1
release-4-2-2
release-4-2-3

I would say that some users may choose to install the theme packages if they want to play with Dogtag as standalone and for example workaround some limitation in FreeIPA CLI/UI. In that case, the at least the dogtag-pki-console-theme theme package would be still pulling full java:

dogtag-pki-theme.spec:
...
BuildRequires:    java-devel >= 1:1.7.0
BuildRequires:    jpackage-utils >= 1.7.5-10
...
%package -n       dogtag-pki-console-theme
...
Requires:         java >= 1:1.7.0

To summarize, from default FreeIPA POV, since FreeIPA 4.1, the Bugzilla is not so concerning any more. It is still not fixed though, the dependency is still there. Matthew or Endi, is this something you plan to fix?

Comment 13 Matthew Harmsen 2015-12-02 17:54:07 UTC

(In reply to Martin Kosek from comment #12)
> FreeIPA 4.1+ does not pull the package automatically since 4.1, as indicated:
> 
> $ git log -1 1026a6387cd392994ec996db53141d16dfcbee29
> commit 1026a6387cd392994ec996db53141d16dfcbee29
> Author: Martin Kosek <mkosek>
> Date:   Wed Jul 23 16:35:13 2014 +0200
> 
>     Do not require dogtag-pki-server-theme
>     
>     Theme package is contains resources for PKI web interface. This interface
>     is not needed by FreeIPA as it rather utilizes it's API. As recommended
> in
>     https://bugzilla.redhat.com/show_bug.cgi?id=1068029#c5, remove this hard
>     dependency.
>     
>     Reviewed-By: Alexander Bokovoy <abokovoy>
> 
> $ git tag --contains 1026a6387cd392994ec996db53141d16dfcbee29
> alpha_1-4-1-0
> alpha_1-4-2-0
> release-4-1-0
> release-4-1-1
> release-4-1-2
> release-4-1-3
> release-4-1-4
> release-4-2-0
> release-4-2-1
> release-4-2-2
> release-4-2-3
> 
> I would say that some users may choose to install the theme packages if they
> want to play with Dogtag as standalone and for example workaround some
> limitation in FreeIPA CLI/UI. In that case, the at least the
> dogtag-pki-console-theme theme package would be still pulling full java:
> 
> dogtag-pki-theme.spec:
> ...
> BuildRequires:    java-devel >= 1:1.7.0
> BuildRequires:    jpackage-utils >= 1.7.5-10
> ...
> %package -n       dogtag-pki-console-theme
> ...
> Requires:         java >= 1:1.7.0
> 
> To summarize, from default FreeIPA POV, since FreeIPA 4.1, the Bugzilla is
> not so concerning any more. It is still not fixed though, the dependency is
> still there. Matthew or Endi, is this something you plan to fix?

I am going to CLOSE this bug as WONTFIX for the following two reasons:

    * If someone wants to play around with Dogtag standalone, they only require
      downloading the dogtag-pki-server-theme package which has no runtime
      requirement on java.
    * They will only need to install dogtag-pki-console-theme if they are using
      the Dogtag pki-console, which requires full GUI java anyways.  So although
      dogtag-pki-console-theme itself may not technically require a java runtime
      requirement, it seems somewhat silly to re-spin the package simply for
      this reason since it is a useless package without pki-console which
      requires full GUI java.