Bug 1069158

Summary: Add permission for a template\vmpool fail
Product: [Retired] oVirt Reporter: Ilanit Stein <istein>
Component: ovirt-engine-coreAssignee: bugs <bugs>
Status: CLOSED DUPLICATE QA Contact: Ilanit Stein <istein>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.4CC: acathrow, gklein, iheim, juan.hernandez, ofrenkel, yeylon
Target Milestone: ---Keywords: Regression, TestBlocker, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: virt
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-24 13:45:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
logs none

Description Ilanit Stein 2014-02-24 11:12:28 UTC
Created attachment 866939 [details]
logs

Description of problem:

There are cases on VMs test, that seem to fail on same issue:
1. Add a template permission to a group	
2. Add user role to VM pool

Failure on engine.log:
AddPermissionCommand] (ajp--127.0.0.1-8702-10) [524] Command org.ovirt.engine.core.bll.AddPermissionCommand throw exception: java.lang.NullPointerException 

REST request for case 1:
addTemplatePermissionsToGroup(True, group='Everyone', template='domain_template')

2014-02-10 16:12:06,738 - MainThread - permissions - DEBUG - CREATE request content is --  url:/api/templates/292cc373-8f31-45c6-8e4a-5b3351dd7518/permissions body:<permission>
    <role href="/api/roles/def00008-0000-0000-0000-def000000008" id="def00008-0000-0000-0000-def000000008">
        <name>TemplateAdmin</name>
        <description>Administrator Role, permission for all operations on a specific Template</description>
        <link href="/api/roles/def00008-0000-0000-0000-def000000008/permits" rel="permits"/>
        <mutable>false</mutable>
        <administrative>true</administrative>
    </role>
    <group href="/api/groups/eee00000-0000-0000-0000-123456789eee" id="eee00000-0000-0000-0000-123456789eee">
        <name>Everyone</name>
        <link href="/api/groups/eee00000-0000-0000-0000-123456789eee/permissions" rel="permissions"/>
        <link href="/api/groups/eee00000-0000-0000-0000-123456789eee/roles" rel="roles"/>
        <link href="/api/groups/eee00000-0000-0000-0000-123456789eee/tags" rel="tags"/>
        <external_id>eee00000000000000000123456789eee</external_id>
    </group>
</permission>

REST request for case 2:
addVmPoolPermissionToUser(True, user='admin', vmpool='rest_testPool', role='UserRole')

2014-02-10 16:34:23,189 - MainThread - permissions - DEBUG - CREATE request content is --  url:/api/users/fdfc627c-d875-11e0-90f0-83df133b58cc/permissions body:<permission>
    <role href="/api/roles/00000000-0000-0000-0001-000000000001" id="00000000-0000-0000-0001-000000000001">
        <name>UserRole</name>
        <description>Standard User Role</description>
        <link href="/api/roles/00000000-0000-0000-0001-000000000001/permits" rel="permits"/>
        <mutable>false</mutable>
        <administrative>false</administrative>
    </role>
    <vmpool href="/api/vmpools/94a92cae-19b0-40fa-a36a-1f2a477a7b7e" id="94a92cae-19b0-40fa-a36a-1f2a477a7b7e">
        <actions>
            <link href="/api/vmpools/94a92cae-19b0-40fa-a36a-1f2a477a7b7e/allocatevm" rel="allocatevm"/>
        </actions>
        <name>rest_testPool</name>
        <link href="/api/vmpools/94a92cae-19b0-40fa-a36a-1f2a477a7b7e/permissions" rel="permissions"/>
        <size>2</size>
        <cluster href="/api/clusters/ed4c0e4a-30e6-4e1b-a79b-f86c3f59c423" id="ed4c0e4a-30e6-4e1b-a79b-f86c3f59c423"/>
        <template href="/api/templates/5bd45174-ac02-47d9-ab4d-b4e10bf6fea2" id="5bd45174-ac02-47d9-ab4d-b4e10bf6fea2"/>
        <prestarted_vms>0</prestarted_vms>
        <max_user_vms>1</max_user_vms>
    </vmpool>
</permission>

Version-Release number of selected component (if applicable):
ovirt-engine-3.4.0-0.11.beta3.el6.noarch

This bug started to show up at version:
ovirt-engine-3.4.0-0.7.beta2.el6.noarch
It did not exist on:
ovirt-engine-3.4.0-0.5.beta1.el6.noarch

It also fail on: rhevm-3.4.0-0.2.1959.cc71493.master.el6evart-1.0.4-6v34

How reproducible:
100%

Expected results:
Add permission should succeed.

Additional info:
Test link: http://jenkins.qa.lab.tlv.redhat.com:8080/view/Compute/view/3.4-git/view/Virt/job/3.4-git-compute-virt-reg_vms-rest-nfs/36/

Comment 1 Omer Frenkel 2014-02-24 13:39:30 UTC
probably the same issue as in bug 1064829
please re-test once its solved

Comment 2 Juan Hernández 2014-02-24 13:45:13 UTC

*** This bug has been marked as a duplicate of bug 1064829 ***