Bug 1069566
| Summary: | Review Request: python-gerrit-view -- A set of tools to query/view Gerrit patch reviews and their Zuul status | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kashyap Chamarthy <kchamart> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | kchamart, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-27 14:12:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kashyap Chamarthy
2014-02-25 10:05:36 UTC
Correct SPEC: http://kashyapc.fedorapeople.org/spec-files/python-gerrit-view.spec (Thanks to Parag Nemade for packaging advice.) Successful Koji scratch build: $ koji build --scratch rawhide ../SRPMS/python-gerrit-view-0.3.0-1.fc20.src.rpm Uploading srpm: ../SRPMS/python-gerrit-view-0.3.0-1.fc20.src.rpm [====================================] 100% 00:00:01 25.15 KiB 13.17 KiB/sec Created task: 6568385 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6568385 Watching tasks (this may be safely interrupted)... 6568385 build (rawhide, python-gerrit-view-0.3.0-1.fc20.src.rpm): open (arm02-builder06.arm.fedoraproject.org) 6568386 buildArch (python-gerrit-view-0.3.0-1.fc20.src.rpm, noarch): open (arm02-builder19.arm.fedoraproject.org) 6568385 build (rawhide, python-gerrit-view-0.3.0-1.fc20.src.rpm): open (arm02-builder06.arm.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 6568386 buildArch (python-gerrit-view-0.3.0-1.fc20.src.rpm, noarch): open (arm02-builder19.arm.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 6568385 build (rawhide, python-gerrit-view-0.3.0-1.fc20.src.rpm) completed successfully Review:-
+ Package build successfully in rawhide mock
+ Source verified with upstream as (sha256sum)
srpm tarball :12c8272c7caf2e9d63ef4cf4d312be1b3ead8562dc9052a6490a2548b0b8dad6
upstream tarball : 12c8272c7caf2e9d63ef4cf4d312be1b3ead8562dc9052a6490a2548b0b8dad6
+ rpmlint on generated rpms gave output
python-gerrit-view.noarch: E: explicit-lib-dependency python-gerritlib
python-gerrit-view.noarch: W: no-manual-page-for-binary czuul
python-gerrit-view.noarch: W: no-manual-page-for-binary qgerrit
python-gerrit-view.noarch: W: no-manual-page-for-binary cgerrit
python-gerrit-view.src: W: spelling-error %description -l en_US qgerrit -> Merritt
python-gerrit-view.src: W: spelling-error %description -l en_US cgerrit -> Merritt
python-gerrit-view.src: W: spelling-error %description -l en_US czuul -> Cozumel
2 packages and 0 specfiles checked; 1 errors, 6 warnings.
==> Error can be ignored
+ License of this package is ASL 2.0 which is given in source header.
- Package contains duplicate files
Suggestions:
1) build.log showed messages like
warning: File listed twice: /usr/lib/python2.7/site-packages/gerrit_view-0.3.0-py2.7.egg-info
your %files should be
%files
%doc README.rst
%{_bindir}/*
%{python2_sitelib}/gerrit_view-%{version}*
Address the above comments. Updated SPEC, regenerated SRPM: http://kashyapc.fedorapeople.org/spec-files/python-gerrit-view.spec http://kashyapc.fedorapeople.org/srpms/python-gerrit-view-0.3.0-2.fc20.src.rpm Looks good now. APPROVED. and make sure you will have no Requires: in duplicate like this one Requires: python-urwid Thanks a lot for the review, Parag. Fixed duplicate entry of 'python-urwid' in Requires. Updated SPEC, and regenerated SRPM: http://kashyapc.fedorapeople.org/spec-files/python-gerrit-view.spec http://kashyapc.fedorapeople.org/srpms/python-gerrit-view-0.3.0-3.fc20.src.rpm Thanks for the update. The SPEC file looks corrected now. New Package SCM Request ======================= Package Name: python-gerrit-view Short Description: A set of tools to query/view Gerrit patch reviews and their Zuul status Owners: kashyapc Branches: f20 el6 epel7 InitialCC: Git done (by process-git-requests). Can this be closed? Yes, sorry for the delay in response, was away on vacation. ping is this built already? Yes it is. (That's what I meant in my previous reply. Sorry for being not clear.) $ koji latest-build f21 python-gerrit-view Build Tag Built by ---------------------------------------- -------------------- ---------------- python-gerrit-view-0.3.2-2.fc21 f21 ausil $ any plans for el6 and epel7 builds? Parag, no plans for EL6 or EPEL7 unless someone requests for it. Thanks. I will close this review then as this package is already built for required branches. |