Bug 1070125

Summary:	Review Request: python-selenium - Python bindings for Selenium
Product:	[Fedora] Fedora	Reporter:	Dhiru Kholia <dhiru>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mrunge, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	python-selenium-2.40.0-2.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-28 17:08:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dhiru Kholia 2014-02-26 09:46:55 UTC

Spec URL: https://bitbucket.org/dhiru/packages/raw/master/python-selenium/python-selenium.spec
SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/python-selenium/python-selenium-2.40.0-1.fc20.src.rpm
Description: 
Fedora Account System Username: halfie

Comment 1 Parag AN(पराग) 2014-02-27 08:02:50 UTC

Review:-

+ Package build successfully in rawhide mock

+ Source verified with upstream as (sha256sum)
srpm tarball :108beb7aa97b974323bb75fdf350c3238ddfdafe1f0cb4723bcfbae71a6b6734
upstream tarball : 108beb7aa97b974323bb75fdf350c3238ddfdafe1f0cb4723bcfbae71a6b6734

- rpmlint on generated rpms gave output
3 packages and 0 specfiles checked; 44 errors, 0 warnings.

+ License of this package is ASL 2.0 which is given in source header.


Suggestions:
1) rpmlint complained non-executable-script error.
http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries

you want to fix this in %prep for required files as seen in rpmlint output.

Comment 2 Dhiru Kholia 2014-02-27 18:34:42 UTC

Updated (and fixed) URLs,

Spec URL: https://bitbucket.org/dhiru/packages/raw/master/python-selenium/python-selenium.spec
SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/python-selenium/python-selenium-2.40.0-2.fc20.src.rpm

Thanks for the feedback.

Comment 3 Parag AN(पराग) 2014-02-28 07:12:10 UTC

Thanks. Looks good now.

APPROVED.

Comment 4 Dhiru Kholia 2014-02-28 09:48:05 UTC

New Package SCM Request
=======================
Package Name: python-selenium
Short Description: Python bindings for Selenium
Owners: halfie
Branches: f20
InitialCC: paragn

Comment 5 Gwyn Ciesla 2014-02-28 12:58:51 UTC

Git done (by process-git-requests).

Comment 6 Dhiru Kholia 2014-02-28 17:08:07 UTC

All set now :-)

Comment 7 Fedora Update System 2014-03-08 20:04:15 UTC

python-selenium-2.40.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-selenium-2.40.0-2.fc20

Comment 8 Fedora Update System 2014-03-13 05:04:32 UTC

python-selenium-2.40.0-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.