Bug 1070522

Summary:	The outlier column in the suspect metrics report renders incorrect values
Product:	[JBoss] JBoss Operations Network	Reporter:	John Sanda <jsanda>
Component:	Core Server, Storage Node	Assignee:	Lukas Krejci <lkrejci>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	JON 3.2	CC:	ahovsepy, hrupp, jshaughn, mithomps, mmahoney
Target Milestone:	ER05
Target Release:	JON 3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1070521	Environment:
Last Closed:	2014-12-11 13:59:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1070521
Bug Blocks:

Description John Sanda 2014-02-27 02:33:34 UTC

+++ This bug was initially created as a clone of Bug #1070521 +++

Description of problem:
The Outlier column always renders a value of zero due to a bug in MeasurementOOBManagerBean. The methods,

  * getHighestNOOBsForGroup
  * getHighestNOOBsForResource
  * getSchedulesWithOOBs 

all execute a query to fetch one hour data that is needed in order to compute outliers. That query is executed against the legacy one hour data table in the relational database; consequently, it always returns an empty result set. This in turn produces always produces outliers of zero.

The above methods are also called to render the resource and group OOB Metrics portlet. I have reviewed the code the involved with Mike Thompson. I do not think that the portlets are affected by this because they do not use the outlier property in MeasurementOOBComposite. Mike please chime in here if I am wrong.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Jay Shaughnessy 2014-09-05 21:30:20 UTC

We need to investigate the suspect metrics report and these values.  There may be issues given what this says and also what Mike was showing me today.

Comment 4 Simeon Pinder 2014-09-29 08:12:49 UTC

Moving into ER05 as didn't make the ER04 cut.

Comment 5 Lukas Krejci 2014-10-13 11:37:44 UTC

master: 7ceb5f74938f720919c378a93ab82a0e66e56702
release/jon3.3.x: bc9b41d30ef73103771f9530c6ad3fbc99827eb2
Author: Lukas Krejci <lkrejci>
Date:   Mon Oct 13 13:34:44 2014 +0200

    [BZ 1070521] Fixed retrieval of OOB datapoints.
    
    (cherry picked from commit 7ceb5f74938f720919c378a93ab82a0e66e56702)

Comment 6 Simeon Pinder 2014-10-21 20:24:29 UTC

Moving to ON_QA as available to test with the latest brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=394734

Comment 7 Matt Mahoney 2014-10-29 13:16:56 UTC

Verified in ER05.