Bug 1070600
Summary: | linux-firmware - change in descriptions | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | poma <pomidorabelisima> | ||||
Component: | linux-firmware | Assignee: | David Woodhouse <dwmw2> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 20 | CC: | dwmw2, kernel-maint | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | x86_64 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2014-03-04 19:50:36 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
poma
2014-02-27 08:24:46 UTC
Created attachment 868349 [details]
linux-firmware - iwlwifi diff
I'm not going to change Source0 to point at googlesource. That isn't where we're getting things at all these days, because they're git snapshots I do locally. I'll figure out the appropriate thing to put there. As for the description change, it's technically correct. I might make it a bit less specific though and change it to "... the Intel wireless drivers..." instead of iwlwifi. I don't want to repeat this exercise when iwlwifi changes to some other name in the future, or we have a HW specific driver show up. OK, if it is a locally generated tarball, this would suffice: Source0: %{name}-%{version}.tar.gz (In reply to Josh Boyer from comment #2) > I'm not going to change Source0 to point at googlesource. That isn't where > we're getting things at all these days, because they're git snapshots I do > locally. I'll figure out the appropriate thing to put there. OK, if it is locally generated tarball, this should suffice: Source0: %{name}-%{version}.tar.gz > As for the description change, it's technically correct. I might make it a > bit less specific though and change it to "... the Intel wireless > drivers..." instead of iwlwifi. I don't want to repeat this exercise when > iwlwifi changes to some other name in the future, or we have a HW specific > driver show up. Practice makes perfect! :) It's OK, just as long as it does not mention non-existent module. This is the Bugzilla fault! Only one 'Source0'! :) Fixed in git. This will be included in whatever build we do next for linux-firmware in rawhide. Thanks. |