Bug 1070887

Summary: The service status option in shinken init scripts returns wrong results
Product: [Fedora] Fedora EPEL Reporter: Ignacio Torres Masdeu <ignacio>
Component: shinkenAssignee: David Hannequin <david.hannequin>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: el6CC: david.hannequin
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: shinken-1.4.1-2.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-19 08:51:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ignacio Torres Masdeu 2014-02-27 16:30:49 UTC
Description of problem:

When checking the status of a service the init script of shinken components uses the status function in a way that returns wrong results.

Version-Release number of selected component (if applicable):

shinken-1.4.1-1.el6.noarch
shinken-arbiter-1.4.1-1.el6.noarch
shinken-reactionner-1.4.1-1.el6.noarch
shinken-scheduler-1.4.1-1.el6.noarch
shinken-broker-1.4.1-1.el6.noarch
shinken-poller-1.4.1-1.el6.noarch
shinken-receiver-1.4.1-1.el6.noarch

How reproducible:

Install shinken and run service <component> status

Steps to Reproduce:

1. yum install shinken shinken-{arbiter,broker,poller,reactionner,receiver,scheduler}
2. service shinken-poller status

Actual results:

# service shinken-poller status
shinken-poller dead but subsys locked

Expected results:

[root shinken]# service shinken-poller status
shinken-poller (pid  1360) is running...


The process is running so I expected to see the parent.

# ps xaf | grep poller
 1360 ?        S      0:00 python /usr/sbin/shinken-poller -d -c /etc/shinken/pollerd.ini
 1365 ?        S      0:00  \_ python /usr/sbin/shinken-poller -d -c /etc/shinken/pollerd.ini

Additional info:

Patching this problem is trivial. The only action needed is using the -p flag in the status function. If we take /etc/init.d/shinken-poller as an example:

85c85
<         status $prog
---
>         status -p $pidfile $prog

Comment 1 Fedora Update System 2014-03-01 09:56:09 UTC
shinken-1.4.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/shinken-1.4.1-2.el6

Comment 2 Fedora Update System 2014-03-01 13:16:17 UTC
shinken-1.4.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/shinken-1.4.1-2.fc19

Comment 3 Fedora Update System 2014-03-02 03:45:16 UTC
Package shinken-1.4.1-2.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing shinken-1.4.1-2.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-3322/shinken-1.4.1-2.fc19
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2014-03-06 10:29:43 UTC
shinken-1.4.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/shinken-1.4.1-2.fc20

Comment 5 Fedora Update System 2014-03-19 08:51:42 UTC
shinken-1.4.1-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2014-03-19 20:22:35 UTC
shinken-1.4.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2014-04-02 09:29:15 UTC
shinken-1.4.1-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.