Bug 1071501
Summary: | [drpm] fallback to full RPM download on drpm failure | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Garry T. Williams <gtwilliams> |
Component: | dnf | Assignee: | Ales Kozumplik <akozumpl> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 20 | CC: | akozumpl, gtwilliams, jonathan, jzeleny, pnemade, rholy |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | dnf-0.4.19-1.fc20 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-03-25 08:13:54 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Garry T. Williams
2014-03-01 00:52:03 UTC
Garry, the errors from prelink are something you regularly see on the box or not? (In reply to Ales Kozumplik from comment #1) > Garry, the errors from prelink are something you regularly see on the box or > not? Yes. I have been meaning to report this, but haven't managed to get around to it. The error message has /seemed/ benign to me. I removed prelink about two months ago. So what is probably happening is that the call to applydeltarpm fails at that point and that leads to the missing rebuilt DRPM. It's still a bug as DNF should either stop right at that point or try to download the full .rpm instead. But never carry on and traceback. Fixed by 03ffe68: DNF will now stop correctly if drpm rebuilding fails, /var/log/dnf.log will contain more detailed information and also a command line used to spawn the rebuilding process: if that fails for reasons beyond DNF's control (like the prelink error here) we won't consider fallback to full RPM download. Instead, please disable drpm downloads. Garry, if you'd like to test a nightly version with the fix, try our CI builds: http://jenkins.cloud.fedoraproject.org/job/DNF/lastSuccessfulBuild/artifact/ Thank you for the report. dnf-0.4.17-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/dnf-0.4.17-1.fc20 Um, I think this isn't the best fix. When I originally wrote yum-presto, one of the requirements was that if a deltarpm build fails, we should always fall back on downloading the full rpm. There are a few reasons why applying the deltarpm may fail (the user changes some non-config files on the filesystem), and the only solution is to download the full rpm, so let's just automatically do it. (In reply to Jonathan Dieter from comment #6) > Um, I think this isn't the best fix. When I originally wrote yum-presto, > one of the requirements was that if a deltarpm build fails, we should always > fall back on downloading the full rpm. > > There are a few reasons why applying the deltarpm may fail (the user changes > some non-config files on the filesystem), and the only solution is to > download the full rpm, so let's just automatically do it. Hi Jonathan, I see, thanks for explaining. I only maintain this DNF part for a very short time so information like this is new and important to me. Reopening, I really need to add a proper fallback support. (In reply to Ales Kozumplik from comment #4) > Garry, if you'd like to test a nightly version with the fix, try our CI > builds: > > http://jenkins.cloud.fedoraproject.org/job/DNF/lastSuccessfulBuild/artifact/ If it's any help, I did install that build and it apparently is fine. However, I cannot reproduce the original problem because I have no idea what caused it in the first place. I also note Jonathan's comment 6 and concur. I see no reason to fail when there's an obvious recovery path. I have not had prelink installed for quite a while. I do not think this should lead to any problems in dnf or dnf presto. This is not an unusual configuration. Finally, thank you both for your support and dnf. It rocks. Package dnf-0.4.17-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing dnf-0.4.17-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-3465/dnf-0.4.17-1.fc20 then log in and leave karma (feedback). Just so you know, dnf-0.4.17-1.fc20 now makes the prelink problem a fatal error. It wasn't like that before. Now the only way around the problem is to disable deltarpm. Since I do not have prelink installed, I really don't know why this happens here. garry@vfr$ sudo dnf update ... /usr/sbin/prelink: No such file or directory prelink not installed, cannot undo prelinkingError: Error downloading packages: nss-3.15.5-1.fc20.x86_64: Delta RPM rebuild failed nss-softokn-3.15.5-2.fc20.x86_64: Delta RPM rebuild failed libdrm-2.4.52-1.fc20.x86_64: Delta RPM rebuild failed nss-util-3.15.5-1.fc20.x86_64: Delta RPM rebuild failed nss-softokn-freebl-3.15.5-2.fc20.x86_64: Delta RPM rebuild failed garry@vfr$ apparently, prelink is needed for the applydeltarpm invocation. However from DNF's point of view, the current result is the expected one: fail gracefully, display reasonable error message, do not crash. Mind you, I'm still working on the fallback fix (that's why this is still open). dnf-0.4.17-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. Fallbacking added by a2e7f7b upstream. dnf-0.4.18-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/dnf-0.4.18-1.fc20 This is fixed with dnf-0.4.18-1.fc20.noarch . Thank you! Package dnf-0.4.18-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing dnf-0.4.18-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-3999/dnf-0.4.18-1.fc20 then log in and leave karma (feedback). dnf-0.4.19-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/dnf-0.4.19-1.fc20 dnf-0.4.19-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |