Bug 1072063

Summary: Review Request: python-seqdiag - seqdiag generates sequence-diagram images from text
Product: [Fedora] Fedora Reporter: Dridi Boukelmoune <dridi.boukelmoune>
Component: Package ReviewAssignee: Mukundan Ragavan <nonamedotc>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: nonamedotc, package-review
Target Milestone: ---Flags: nonamedotc: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: python-seqdiag-0.9.0-2.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-04-27 09:06:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dridi Boukelmoune 2014-03-03 20:09:32 UTC
Spec URL: https://bitbucket.org/dridi/fedora_packages/downloads/python-seqdiag.spec
SRPM URL: https://bitbucket.org/dridi/fedora_packages/downloads/python-seqdiag-0.9.0-1.fc19.src.rpm
Description:
seqdiag and its family generate diagram images from simply text file.

Features:
- Generates beautiful diagram images from simple text format (similar to
  graphviz’s DOT format)
- Layouts diagram elements automatically
- Embeds to many documentations; Sphinx, Trac, Redmine and some wikis

- Supports many types of diagrams
  - sequence diagram (with this package)
  - block diagram (with the blockdiag package)
  - activity diagram (with the actdiag package)
  - logical network diagram (with the nwdiag package)

Enjoy documentation with seqdiag !

Fedora Account System Username: dridi

Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6591936

Comment 1 Mukundan Ragavan 2014-03-03 20:34:59 UTC
I will take it.

Comment 2 Dridi Boukelmoune 2014-03-03 22:00:28 UTC
Hi,

Thank you, that was unexpectedly fast !

Please consider reviewing bug 1072064 and bug 1072065. It basically the *same* spec for all three packages, except that nwdiag has *minor* difference because it contains three programs.

Any feedback here would probably apply for those too.

Comment 3 Mukundan Ragavan 2014-03-03 22:14:37 UTC
I saw those too ... I guess I can take it! Review swap? :)

Comment 4 Mukundan Ragavan 2014-03-03 23:48:00 UTC
I want to clarify some aspects (for myself). Please take a look below for a detailed review.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated". 10 files
     have unknown license. Detailed output of licensecheck in
     /home/mukundan/personal/pkgs/reviews/1072063-python-
     seqdiag/licensecheck.txt

---> This does not seem to be a problem.

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.

---> Please fix.

[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-seqdiag

---> Not applicable here.

[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.

---> Looks good.

----------------------------------------------------------------------
Ran 44 tests in 1.973s
OK

[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-seqdiag-0.9.0-1.fc21.noarch.rpm
          python3-seqdiag-0.9.0-1.fc21.noarch.rpm
          python-seqdiag-0.9.0-1.fc21.src.rpm
python-seqdiag.noarch: W: summary-not-capitalized C seqdiag generates sequence-diagram images from text
python-seqdiag.noarch: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic
python-seqdiag.noarch: W: spelling-error %description -l en_US blockdiag -> blockage
python-seqdiag.noarch: W: spelling-error %description -l en_US actdiag -> Acadia
python-seqdiag.noarch: W: spelling-error %description -l en_US nwdiag -> diagonal


python-seqdiag.noarch: W: incoherent-version-in-changelog 0.9.0 ['0.9.0-1.fc21', '0.9.0-1']

---> Please fix this.

python-seqdiag.noarch: W: spurious-executable-perm /usr/share/man/man1/seqdiag.1.gz

---> Please investigate.



python3-seqdiag.noarch: W: summary-not-capitalized C seqdiag generates sequence-diagram images from text
python3-seqdiag.noarch: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic
python3-seqdiag.noarch: W: spelling-error %description -l en_US blockdiag -> blockage
python3-seqdiag.noarch: W: spelling-error %description -l en_US actdiag -> Acadia
python3-seqdiag.noarch: W: spelling-error %description -l en_US nwdiag -> diagonal
python3-seqdiag.noarch: W: spurious-executable-perm /usr/share/man/man1/seqdiag-3.3.1.gz
python-seqdiag.src: W: summary-not-capitalized C seqdiag generates sequence-diagram images from text
python-seqdiag.src: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic
python-seqdiag.src: W: spelling-error %description -l en_US blockdiag -> blockage
python-seqdiag.src: W: spelling-error %description -l en_US actdiag -> Acadia
python-seqdiag.src: W: spelling-error %description -l en_US nwdiag -> diagonal
3 packages and 0 specfiles checked; 0 errors, 18 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint python3-seqdiag python-seqdiag
python3-seqdiag.noarch: W: summary-not-capitalized C seqdiag generates sequence-diagram images from text
python3-seqdiag.noarch: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic
python3-seqdiag.noarch: W: spelling-error %description -l en_US blockdiag -> blockage
python3-seqdiag.noarch: W: spelling-error %description -l en_US actdiag -> Acadia
python3-seqdiag.noarch: W: spelling-error %description -l en_US nwdiag -> diagonal
python3-seqdiag.noarch: W: spurious-executable-perm /usr/share/man/man1/seqdiag-3.3.1.gz
python-seqdiag.noarch: W: summary-not-capitalized C seqdiag generates sequence-diagram images from text
python-seqdiag.noarch: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic
python-seqdiag.noarch: W: spelling-error %description -l en_US blockdiag -> blockage
python-seqdiag.noarch: W: spelling-error %description -l en_US actdiag -> Acadia
python-seqdiag.noarch: W: spelling-error %description -l en_US nwdiag -> diagonal
python-seqdiag.noarch: W: incoherent-version-in-changelog 0.9.0 ['0.9.0-1.fc21', '0.9.0-1']
python-seqdiag.noarch: W: spurious-executable-perm /usr/share/man/man1/seqdiag.1.gz
2 packages and 0 specfiles checked; 0 errors, 13 warnings.
# echo 'rpmlint-done:'



Requires
--------
python3-seqdiag (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3-blockdiag

python-seqdiag (rpmlib, GLIBC filtered):
    /usr/bin/python2
    python(abi)
    python-blockdiag



Provides
--------
python3-seqdiag:
    python3-seqdiag

python-seqdiag:
    python-seqdiag



Source checksums
----------------
https://bitbucket.org/tk0miya/seqdiag/get/0.9.0.tar.gz :
  CHECKSUM(SHA256) this package     : a4ec570e5245c797c6da3bff575e921a300c6a697ce1a099e606d923069129ae
  CHECKSUM(SHA256) upstream package : a4ec570e5245c797c6da3bff575e921a300c6a697ce1a099e606d923069129ae


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1072063
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 5 Dridi Boukelmoune 2014-03-04 15:41:20 UTC
(In reply to Mukundan Ragavan from comment #3)
> I saw those too ... I guess I can take it! Review swap? :)

Sure, thanks !

Spec URL: https://bitbucket.org/dridi/fedora_packages/downloads/python-seqdiag.spec
SRPM URL: https://bitbucket.org/dridi/fedora_packages/downloads/python-seqdiag-0.9.0-2.fc19.src.rpm

Comment 6 Mukundan Ragavan 2014-03-04 15:58:31 UTC
> Spec URL:
> https://bitbucket.org/dridi/fedora_packages/downloads/python-seqdiag.spec
> SRPM URL:
> https://bitbucket.org/dridi/fedora_packages/downloads/python-seqdiag-0.9.0-2.
> fc19.src.rpm

Thanks for the update. I will look at this soon.




(In reply to Dridi Boukelmoune from comment #5)
> (In reply to Mukundan Ragavan from comment #3)
> > I saw those too ... I guess I can take it! Review swap? :)
> 
> Sure, thanks !
> 

Thanks. Here is mine - https://bugzilla.redhat.com/show_bug.cgi?id=1072028

Comment 7 Mukundan Ragavan 2014-03-04 16:54:19 UTC
Looks fine. Package APPROVED.

Comment 8 Dridi Boukelmoune 2014-03-04 20:16:22 UTC
New Package SCM Request
=======================
Package Name: seqdiag
Short Description: seqdiag generates sequence-diagram images from text
Owners: dridi
Branches: f19 f20
InitialCC:

Comment 9 Gwyn Ciesla 2014-03-06 13:36:14 UTC
Git done (by process-git-requests).

Comment 10 Dridi Boukelmoune 2014-03-07 14:35:39 UTC
I have mistakenly forgotten the "python-" prefix for this package (not in the rpm spec though).

New Package SCM Request
=======================
Package Name: python-seqdiag
Short Description: seqdiag generates sequence-diagram images from text
Owners: dridi
Branches: f19 f20
InitialCC:

Comment 11 Mukundan Ragavan 2014-03-07 14:44:58 UTC
yes, the spec files and package names are correct (comment #4). Unfortunately, I did not notice the title in the bug report either when I did the review.

Comment 12 Gwyn Ciesla 2014-03-07 15:35:51 UTC
Git done (by process-git-requests).

Comment 13 Mukundan Ragavan 2014-03-27 20:09:27 UTC
Can we close this review request now since the package is already built in rawhide? All good?

Comment 14 Fedora Update System 2014-04-17 09:36:03 UTC
python-seqdiag-0.9.0-2.fc19,python-nwdiag-1.0.0-2.fc19,python-actdiag-0.5.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-seqdiag-0.9.0-2.fc19,python-nwdiag-1.0.0-2.fc19,python-actdiag-0.5.1-2.fc19

Comment 15 Fedora Update System 2014-04-17 09:36:20 UTC
python-seqdiag-0.9.0-2.fc20,python-nwdiag-1.0.0-2.fc20,python-actdiag-0.5.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-seqdiag-0.9.0-2.fc20,python-nwdiag-1.0.0-2.fc20,python-actdiag-0.5.1-2.fc20

Comment 16 Fedora Update System 2014-04-18 15:33:46 UTC
python-seqdiag-0.9.0-2.fc20, python-nwdiag-1.0.0-2.fc20, python-actdiag-0.5.1-2.fc20 has been pushed to the Fedora 20 testing repository.

Comment 17 Fedora Update System 2014-04-27 09:06:13 UTC
python-seqdiag-0.9.0-2.fc20, python-nwdiag-1.0.0-2.fc20, python-actdiag-0.5.1-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 18 Fedora Update System 2014-04-27 09:09:38 UTC
python-seqdiag-0.9.0-2.fc19, python-nwdiag-1.0.0-2.fc19, python-actdiag-0.5.1-2.fc19 has been pushed to the Fedora 19 stable repository.