Bug 1072471

Created attachment 870492 [details]
sos report and vdsm.log (host1 is SPM)

Description of problem:
When creating a snapshot to a VM which has several disks attached, which one of them is RO and picking only the RO disk in the snapshot creation window, the RO disk is not included as part of the snapshot's disks table even though the CreateSnapshotVDSCommand was sent to vdsm for that disk. I tried to clone a VM from that snapshot, and the snapshot's RO disk, which was supposed to be part of the snapshot, wasn't cloned for the new cloned VM.

Version-Release number of selected component (if applicable):
rhevm-3.4.0-0.3.master.el6ev.noarch
vdsm-4.14.2-0.2.el6ev.x86_64


How reproducible:
Always

Steps to Reproduce:
On a shared DC with 1 or more hosts and 1 or more storage domains
1. Create a VM with several disks attached, one of them is read-only 
2. Create a snapshot to that VM, pick only the RO disk as part of the snapshot creation
3. Check the 'disks' sub-tab under the new snapshot
4. Try to clone a new VM from that snapshot

Actual results:

CreateSnapshotVDSCommand is executed and sent to vdsm for the RO disk.

adb1-373767ef22fa, ignoreFailoverLimit = false, storageDomainId = 6a14dba2-788d-4be6-9a68-d3bd4100518a, imageGroupId = dc35b751-af41-4cb0-bac6-9316bb95c4a8, imageSizeInBytes = 1073741824, volumeFormat = COW, newIm
ageId = 23812f4e-4c63-4e8e-9b9a-b745580b06e6, newImageDescription = , imageId = 1844028f-22bd-4e3f-98eb-3e008ccd7027, sourceImageGroupId = dc35b751-af41-4cb0-bac6-9316bb95c4a8), log id: 2f6e061f


===========================
Disk dc35b751-af41-4cb0-bac6-9316bb95c4a8 is read-only:

imageID=dc35b751-af41-4cb0-bac6-9316bb95c4a8, domainID=6a14dba2-788d-4be6-9a68-d3bd4100518a, address={bus=0x00, domain=0x0000, slot=0x08, type=pci, function=0x0}, specParams={}, optional=false, propagateErrors=off, device=disk, poolID=54d804e4-5bb5-492e-adb1-373767ef22fa, format=cow, type=disk, readonly=true

===========================
Logical volumes are created to that disk (created several snapshots):

  LV                                   LV Tags
  13b7f8a7-35d7-44ca-ab4b-cc216adfff40 IU_7dd1afc3-7744-4e3d-95a1-5d653b20764c,PU_5cf16efc-2554-47f3-a7bb-7092347a81c7,MD_13
  1844028f-22bd-4e3f-98eb-3e008ccd7027 IU_dc35b751-af41-4cb0-bac6-9316bb95c4a8,PU_6984501a-3ddd-495d-8f67-d4d2bc77398e,MD_12
  1a912d65-affa-4791-a9db-8b47aab0e90f MD_4,PU_00000000-0000-0000-0000-000000000000,IU_7dd1afc3-7744-4e3d-95a1-5d653b20764c
  23812f4e-4c63-4e8e-9b9a-b745580b06e6 MD_14,PU_1844028f-22bd-4e3f-98eb-3e008ccd7027,IU_dc35b751-af41-4cb0-bac6-9316bb95c4a8
  2c4b067a-cdee-444d-9823-4b442604b74a IU_dc35b751-af41-4cb0-bac6-9316bb95c4a8,PU_77451c16-4968-4ec0-b40a-ac7deea021bc,MD_10
  5cf16efc-2554-47f3-a7bb-7092347a81c7 PU_1a912d65-affa-4791-a9db-8b47aab0e90f,IU_7dd1afc3-7744-4e3d-95a1-5d653b20764c,MD_9
  6984501a-3ddd-495d-8f67-d4d2bc77398e IU_dc35b751-af41-4cb0-bac6-9316bb95c4a8,PU_2c4b067a-cdee-444d-9823-4b442604b74a,MD_11
  77451c16-4968-4ec0-b40a-ac7deea021bc IU_dc35b751-af41-4cb0-bac6-9316bb95c4a8,PU_9588b66c-0ec0-4619-aa0d-c5d653ccb9c8,MD_8
  9588b66c-0ec0-4619-aa0d-c5d653ccb9c8 MD_6,IU_dc35b751-af41-4cb0-bac6-9316bb95c4a8,PU_b45e8acc-f5bb-49c6-a3e2-f7c121d55230
  b45e8acc-f5bb-49c6-a3e2-f7c121d55230 PU_00000000-0000-0000-0000-000000000000,IU_dc35b751-af41-4cb0-bac6-9316bb95c4a8,MD_5


But the RO is not presented on UI as part of the snapshot's disks. Cloning a VM from that snapshot wouldn't create a new image for the RO disk 

Expected results:
1) If RO disk is created and is part of the snapshot, its snapshot should be cloned as part of the whole VM snapshot instance clone.
2) The RO disk's snapshot should be presented to user under the VM snapahsot's disks.

Additional info:
sos report and vdsm.log (host1 is SPM)