Bug 1072543
| Summary: | Unable to collect metrics from EAP 6 datasources when a system properties is used in configuration | |||
|---|---|---|---|---|
| Product: | [JBoss] JBoss Operations Network | Reporter: | Larry O'Leary <loleary> | |
| Component: | Plugin -- JBoss EAP 6 | Assignee: | Libor Zoubek <lzoubek> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Filip Brychta <fbrychta> | |
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | JON 3.2 | CC: | fbrychta, lkrejci, lzoubek, myarboro, theute | |
| Target Milestone: | DR01 | |||
| Target Release: | JON 3.3.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: |
Collecting metrics from an EAP 6 datasource failed due to improper handling of returned data types from the DMR, specifically the minimum and maximum pool size settings of a datasource configuration. If a user declared a system property as the value of min-pool-size or max-pool-size, the DMR could not parse the properties. The fix now handles system properties in the datasource configuration file, which fixes the originally reported issue.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1119513 (view as bug list) | Environment: | ||
| Last Closed: | 2014-12-11 14:01:45 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1119513 | |||
|
Description
Larry O'Leary
2014-03-04 18:19:52 UTC
Merged the PR into master
commit 4edaa3b2de2575f6fb875b428ec6db1b20afe0a9
Merge: 769bb64 e86ac44
Author: Lukas Krejci <metlos.github.com>
Date: Tue Apr 22 14:17:41 2014 +0200
Merge pull request #19 from lzoubek/bugs/1072543
[BZ 1072543] Unable to collect metrics from EAP 6 datasources when a system properties is used in configuration
Moving to ON_QA as available to test with brew build of DR01: https://brewweb.devel.redhat.com//buildinfo?buildID=373993 Original issue is fixed. But there is another severe problem related to min-pool-size or max-pool-size containing string value.
When you set min-pool-size or max-pool-size manually in standalone-*.xml to
${rhq.server.datasource.nonxa.maxpool:5} the server is started correctly, but configuration of this resource in JON becomes invalid (string value for those properties is not expected) and any further attempt to update this configuration in JON fails with:
java.lang.NumberFormatException: For input string: "${rhq.server.datasource.nonxa.maxpool:5}"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:481)
at java.lang.Integer.valueOf(Integer.java:582)
at org.rhq.modules.plugins.jbossas7.ConfigurationWriteDelegate.getObjectWithType(ConfigurationWriteDelegate.java:704)
at org.rhq.modules.plugins.jbossas7.ConfigurationWriteDelegate.preparePropertySimple(ConfigurationWriteDelegate.java:529)
at org.rhq.modules.plugins.jbossas7.ConfigurationWriteDelegate.createWriteAttributePropertySimple(ConfigurationWriteDelegate.java:453)
at org.rhq.modules.plugins.jbossas7.ConfigurationWriteDelegate.createWriteAttribute(ConfigurationWriteDelegate.java:332)
at org.rhq.modules.plugins.jbossas7.ConfigurationWriteDelegate.updateProperty(ConfigurationWriteDelegate.java:324)
at org.rhq.modules.plugins.jbossas7.ConfigurationWriteDelegate.updateGenerateOperationFromProperties(ConfigurationWriteDelegate.java:130)
at org.rhq.modules.plugins.jbossas7.ConfigurationWriteDelegate.updateResourceConfiguration(ConfigurationWriteDelegate.java:103)
at org.rhq.modules.plugins.jbossas7.DatasourceComponent.updateResourceConfiguration(DatasourceComponent.java:331)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Both properties must be set to integer and then the configuration update works.
This is different issue, please open another BZ Ok, I will open new one. This is verified on Version : 3.3.0.DR01 Build Number : 6468454:dda0a47 |