Bug 1073376
| Summary: | Review Request: lohit-gurmukhi-fonts - Free Gurmukhi truetype font for Punjabi language | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pravin Satpute <psatpute> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | lohit-gurmukhi-fonts-2.91.0-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-03-11 05:01:34 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pravin Satpute
2014-03-06 10:21:58 UTC
Additional Information: This package was earlier know as lohit-punjabi-fonts, see change proposal for more information https://fedoraproject.org/wiki/Changes/Lohit_Odia_Gurmukhi Review:
+ Package built fine in mock rawhide
+ Source verified with upstream as (sha1256sum)
srpm tarball : 6c2e6a6298e8c527fab30d248d3570be7eb5115b6ce36d180e90f0ff6c37e92c
upstream tarball : 6c2e6a6298e8c527fab30d248d3570be7eb5115b6ce36d180e90f0ff6c37e92c
- rpmlint on generated rpms gave output
lohit-gurmukhi-fonts.noarch: W: spelling-error %description -l en_US truetype -> true type, true-type, trumpeter
lohit-gurmukhi-fonts.noarch: W: dangling-symlink /etc/fonts/conf.d/30-lohit-gurmukhi.conf /usr/share/fontconfig/conf.avail/builddir/build/SOURCES/lohit-gurmukhi-fonts.conf
lohit-gurmukhi-fonts.src: W: spelling-error %description -l en_US truetype -> true type, true-type, trumpeter
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
+ This package provides correct locale (pa) for the Gurmukhi language
config(lohit-gurmukhi-fonts)
font(:lang=pa)
font(lohitgurmukhi)
lohit-gurmukhi-fonts
lohit-punjabi-fonts
+ License is OFL and included in font file as well as separate text file OFL.txt
Suggestions:
1)you should be using
Obsoletes: lohit-punjabi-fonts < 2.5.3-4
2)and fix the dangling-symlink rpmlint warning.
3) Use BR: python2
Updated spec file: http://pravins.fedorapeople.org/lohit-gurmukhi-fonts.spec Updated srpm: http://pravins.fedorapeople.org/lohit-gurmukhi-fonts-2.91.0-2.fc19.src.rpm Still not following in spec Obsoletes: lohit-punjabi-fonts < 2.5.3-4 but you can add this at time of fedora package initial import. APPROVED. New Package SCM Request ======================= Package Name: lohit-gurmukhi-fonts Short Description: Free Gurmukhi truetype font for Punjabi language Owners: pravins Branches: InitialCC: i18n-team fonts-sig Git done (by process-git-requests). Build done for rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6620425 Thanks Parag for detailed review and Jon for GIT process. |