Bug 1073421

Summary:	[RFE] allow additional parameter for engine-backup to omit audit_log data
Product:	[Retired] oVirt	Reporter:	Sven Kieske <s.kieske>
Component:	ovirt-engine-installer	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED WONTFIX	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	low	Docs Contact:
Priority:	medium
Version:	3.3	CC:	bugs, gklein, iheim, rbalakri, sbonazzo, s.kieske, yeylon, ylavi
Target Milestone:	---	Keywords:	FutureFeature, Reopened
Target Release:	3.6.0
Hardware:	x86_64
OS:	Linux
Whiteboard:	integration
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Feature: allow additional parameter for engine-backup to omit audit_log data Reason: Result (if any):	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-04-08 07:25:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1064503
Bug Blocks:

Description Sven Kieske 2014-03-06 12:24:25 UTC

Description of problem:

currently the engine backup does backup the complete audit_log table
including all login/logout events. this can grow quite large when using
rest api.

additionally: you don't need the content of this table for a successful
restore.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:
audit_log gets completly backed up

Expected results:
add an option to engine-backup which allows to omit this data

Additional info:
see this thread on engine-devel ML for more information:
http://lists.ovirt.org/pipermail/engine-devel/2014-March/006658.html

PS: There is no component for engine-backup in this bugzilla to select.

Comment 1 Yedidyah Bar David 2014-10-12 05:49:07 UTC

Mentioned on the above discussion on the list:
1. normally older log entries are automatically deleted [1].
2. We probably want to allow passing arbitrary options to pg_dump. For recent versions, the option '--exclude-table-data' will solve this bug.

[1] http://lists.ovirt.org/pipermail/engine-devel/2014-March/006678.html
[2] http://lists.ovirt.org/pipermail/engine-devel/2014-March/006686.html

I also considered (also?) sourcing /etc/ovirt-engine/engine-backup.d/*.sh or something like that. This will allow a user to redefine the function backupDB to do whatever is required.

Comment 2 Yaniv Lavi 2015-04-07 13:47:39 UTC


*** This bug has been marked as a duplicate of bug 1188132 ***

Comment 3 Yedidyah Bar David 2015-04-08 05:56:21 UTC

I do not agree this is a duplicate, and even if one might claim it is (because one of the reasons to not backup audit_log is to save time), I did not intend to address this one in bug 1188132. I anyway didn't add these options to [1], which is what will be available to engine-backup once it's rewritten (bug 1064503).

[1] https://gerrit.ovirt.org/39190

OTOH, not sure we really need to support this (not saving audit_log).

Note that the admin can control the maximum age of entries that will be kept there, which is 30 days by default (see comment 1).

Also, in a discussion with Doron, he said we should not support allowing passing arbitrary options to pg_dump/pg_restore, because it's extremely important that backup/restore works and does the expected thing.

So I'd vote for simply CLOSE WONTFIX.

Sven, what do you think?

Thanks.

Comment 4 Sven Kieske 2015-04-08 07:13:38 UTC

Well it turned out I do not need this feature that bad.

I still would think it makes sense in a general way to just back up what
is really needed to restore successful, otoh other users might expect the audit log to get backed up to.

My engine backups are just about 5 MB per backup, so I guess this is okay.

I don't remember the last restore time (because that might go up and become critical, when the backupfile grows), but it was not that long.

kind regards

Sven

Comment 5 Yedidyah Bar David 2015-04-08 07:25:59 UTC

Closing, then. Thanks, Sven!