Bug 1074102

This has the incorrect FSF address again. 

Apparently the requires on the subpackage should now be:

   Requires: %{name}%{?_isa} = %{version}-%{release}

(Not sure when that changed happened but it makes sense.)

These are small, though, and not "MUST" items. Overall review passes; please fix the above when you can.




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (with incorrect FSF address)", "Unknown or generated". 1 files have
     unknown license. Detailed output of licensecheck in /home/mattdm/tmp/rpm-
     ostree/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rpm-ostree-
     autobuilder
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Package should not use obsolete m4 macros


Rpmlint
-------
Checking: rpm-ostree-2014.5.4.g9aa1bdb-1.fc21.x86_64.rpm
          rpm-ostree-autobuilder-2014.5.4.g9aa1bdb-1.fc21.x86_64.rpm
          rpm-ostree-2014.5.4.g9aa1bdb-1.fc21.src.rpm
rpm-ostree.x86_64: W: incoherent-version-in-changelog 2014.5-1 ['2014.5.4.g9aa1bdb-1.fc21', '2014.5.4.g9aa1bdb-1']
rpm-ostree.x86_64: W: only-non-binary-in-usr-lib
rpm-ostree.x86_64: E: incorrect-fsf-address /usr/share/doc/rpm-ostree/COPYING
rpm-ostree.x86_64: W: no-manual-page-for-binary rpm-ostree
rpm-ostree-autobuilder.x86_64: E: explicit-lib-dependency libguestfs-gobject
rpm-ostree-autobuilder.x86_64: W: no-documentation
rpm-ostree-autobuilder.x86_64: E: non-executable-script /usr/share/rpm-ostree-autobuilder/rpm-ostree-export-journal-to-serialdev 0644L /bin/bash
rpm-ostree-autobuilder.x86_64: W: no-manual-page-for-binary rpm-ostree-autobuilder
rpm-ostree.src: W: invalid-url Source0: rpm-ostree-2014.5.4.g9aa1bdb.tar.xz
3 packages and 0 specfiles checked; 3 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint rpm-ostree rpm-ostree-autobuilder
rpm-ostree.x86_64: W: incoherent-version-in-changelog 2014.5-1 ['2014.5.4.g9aa1bdb-1.fc21', '2014.5.4.g9aa1bdb-1']
rpm-ostree.x86_64: W: only-non-binary-in-usr-lib
rpm-ostree.x86_64: E: incorrect-fsf-address /usr/share/doc/rpm-ostree/COPYING
rpm-ostree.x86_64: W: no-manual-page-for-binary rpm-ostree
rpm-ostree-autobuilder.x86_64: E: explicit-lib-dependency libguestfs-gobject
rpm-ostree-autobuilder.x86_64: W: no-documentation
rpm-ostree-autobuilder.x86_64: E: non-executable-script /usr/share/rpm-ostree-autobuilder/rpm-ostree-export-journal-to-serialdev 0644L /bin/bash
rpm-ostree-autobuilder.x86_64: W: no-manual-page-for-binary rpm-ostree-autobuilder
2 packages and 0 specfiles checked; 3 errors, 5 warnings.
# echo 'rpmlint-done:'



Requires
--------
rpm-ostree (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/yum
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgsystem.so.0()(64bit)
    libjson-glib-1.0.so.0()(64bit)
    libostree-1.so.1()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

rpm-ostree-autobuilder (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/gjs
    /usr/bin/guestmount
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgsystem.so.0()(64bit)
    libguestfs-gobject
    libjson-glib-1.0.so.0()(64bit)
    libostree-1.so.1()(64bit)
    libpthread.so.0()(64bit)
    libreadline.so.6()(64bit)
    rpm-ostree
    rtld(GNU_HASH)



Provides
--------
rpm-ostree:
    rpm-ostree
    rpm-ostree(x86-64)

rpm-ostree-autobuilder:
    rpm-ostree-autobuilder
    rpm-ostree-autobuilder(x86-64)



Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -rn rpm-ostree-2014.5.4.g9aa1bdb-1.el7.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

(In reply to Matthew Miller from comment #1)
> This has the incorrect FSF address again. 

Fixed.

> Apparently the requires on the subpackage should now be:
> 
>    Requires: %{name}%{?_isa} = %{version}-%{release}

Fixed.  Thanks for the review!

New Package SCM Request
=======================
Package Name: rpm-ostree
Short Description: Commit RPMs to an OSTree repository
Owners: walters mattdm
Branches: f20
InitialCC:

Git done (by process-git-requests).