Bug 1074170
| Summary: | setup.py script executes pkg-config even on "clean" target | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthew Garrett <mjg59> | ||||||
| Component: | libvirt-python | Assignee: | Daniel Berrangé <berrange> | ||||||
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 20 | CC: | berrange, crobinso, jx871031, veillard, virt-maint | ||||||
| Target Milestone: | --- | Flags: | jx871031:
needinfo?
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-03-25 21:16:38 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Thanks for the report. I pushed a series of patches upstream that should fix this. Just closing as UPSTREAM, a new version will be in rawhide within a couple of weeks. Created attachment 1158143 [details]
libvirt-python-patch
(In reply to lcnuaa from comment #2) > Created attachment 1158143 [details] > libvirt-python-patch sorry，everyone. I want to download the patch about setup.py cleaning. But something went wrong..I uploaded the wrong attachment... My attachment is incorrect,and I don't know how to delete it. So don't download or review the attachment of mine!!!!!!!!!!!!!!!!!!!!!!! |
Created attachment 872217 [details] Don't run pkgconfig when running setup.py clean python setup.py clean runs pkgconfig even though the values aren't used, which interacts badly with our build system (we call clean to build the package source before we've installed any build dependencies). The attached patch works around it for our specific case, but I'm not sure what the standard python approach is.