Bug 1075174
| Summary: | Migration failure occurring with VIR_DOMAIN_XML_MIGRATABLE (Target device address type none does not match source pci) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Solly Ross <sross> |
| Component: | libvirt | Assignee: | Jiri Denemark <jdenemar> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 20 | CC: | acathrow, berrange, clalancette, crobinso, dallan, itamar, jforbes, laine, libvirt-maint, sross, veillard, virt-maint |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-1.1.3.4-4.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-04-14 22:37:49 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Solly Ross
2014-03-11 16:10:49 UTC
Created attachment 873410 [details]
libvirtd.log from the source host
Created attachment 873412 [details]
libvirtd.log from the destination host
Oh, I forgot the original XML won't be there when xmlin is used. Could you also attach domain XML produced by "virsh dumpxml $DOMAIN" and "virsh dumpxml --migratable $DOMAIN"? And please, attach them to this bugzilla rather than gist.github.com or another service. Anyway, looking at the code it seems we are not doing the right thing when checking ABI stability of the provided migration XML. However, I wasn't able to reproduce the error with my domain. Created attachment 873614 [details]
virsh dumpxml
Created attachment 873616 [details]
virsh dumpxml --migratable
Created attachment 873618 [details]
xml used by nova (with quotes changed, basically same as virsh dumpxml --migratable)
I made a change to virDomainDefCheckABIStability function to log both source and destination XMLs when the check fails so that it's easier to debug similar issues in the future:
commit 287e2b395aa5357491e80e06ea82ba63c3a1075e
Author: Jiri Denemark <jdenemar>
Date: Wed Mar 12 11:50:12 2014 +0100
Make ABI stability issue easier to debug
When ABI stability check fails, we only log the error message describing
the incompatibility. Let's log both XMLs in case of an error to make it
easier to analyze where and why the stability check failed.
Signed-off-by: Jiri Denemark <jdenemar>
The bug is already fixed upstream by commit v1.1.3-89-g7d70481, which was made for bug 994364. *** This bug has been marked as a duplicate of bug 994364 *** Actually, since the bug description indicates, this was observed on Fedora 20, let's reopen the bug and move it Fedora component. The bug should be fixed by the following upstream commit:
commit 7d704812b9c50cd3804dd1e7f9e2ea3e75fdc847
Author: Michal Privoznik <mprivozn>
AuthorDate: Thu Oct 10 10:53:56 2013 +0200
Commit: Michal Privoznik <mprivozn>
CommitDate: Fri Oct 11 10:31:35 2013 +0200
qemu: Introduce qemuDomainDefCheckABIStability
https://bugzilla.redhat.com/show_bug.cgi?id=994364
Whenever we check for ABI stability, we have new xml (e.g. provided by
user, or obtained from snapshot, whatever) which we compare to old xml
and see if ABI won't break. However, if the new xml was produced via
virDomainGetXMLDesc(..., VIR_DOMAIN_XML_MIGRATABLE) it lacks some
devices, e.g. 'pci-root' controller. Hence, the ABI stability check
fails even though it is stable. Moreover, we can't simply fix
virDomainDefCheckABIStability because removing the correct devices is
task for the driver. For instance, qemu driver wants to remove the usb
controller too, while LXC driver doesn't. That's why we need special
qemu wrapper over virDomainDefCheckABIStability which removes the
correct devices from domain XML, produces MIGRATABLE xml and calls the
check ABI stability function.
Signed-off-by: Michal Privoznik <mprivozn>
A scratch build for testing this bug (containing both the above commit and the commit from comment #8) can be downloaded from http://koji.fedoraproject.org/koji/taskinfo?taskID=6632713
This appears to have fixed all of the issues we were experiencing in Nova when trying to use retrieved XML to do migration (after changing the listen addresses). libvirt-1.1.3.4-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libvirt-1.1.3.4-4.fc20 Package libvirt-1.1.3.4-4.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing libvirt-1.1.3.4-4.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-4032/libvirt-1.1.3.4-4.fc20 then log in and leave karma (feedback). libvirt-1.1.3.4-4.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |