Bug 1075218

A rawhide koji build is also available: http://koji.fedoraproject.org/koji/taskinfo?taskID=6622780

Some quick notes from first glance:

* make install DESTDIR=%{buildroot}
  would be %make_install

* Source0:        %{name}-%{version}.tar.gz
  I'd prefer if you will provide link to upstream releases on ftp or http or git

* A configuration file is  /etc/pam_ldap2krb.conf
  Should not be in description. Should be in README which installing to system.

* Group:          security
  Should not present if you have no plans for supporting you package for EL5 or EL6 (forget)

* %{_sysconfdir}/*
  not good. please provide %{_sysconfdir}/pam_ldap2krb.conf

* %{_libdir}/*
  not good. please provide something like upper.

* Tue Mar 11 2014 Kazım SARIKAYA <kazimsarikaya>
  there should be also version of package.

* Requires:       pam libconfuse krb5-workstation openldap
  I'm not sure that we really want to have this dependencies. Some from this should automatically be picked up by RPM.

Also no ldconfig macroses.
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries

i fixed my spec file:

* using %make_install
* adding scm information before Source0 described at https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
* comment group (i have my own repo for my servers and i use group keyword, however for fedora i can comment it )
* rewrite description
* %files section is complete file names not wildcard
* %changelog adding version
* commenting requires 
* adding ldconfig macros.

i intend to add a new koji build task link however. the koji is painfully slow and gives timeout error. hence i think i should not wait it for now.

the rpms can be generated with steps:

1) git clone https://git.sanaldiyar.com/pam_ldap2krb.git
2) ./autogen.sh
3) ./configure
4) make rpmbuild

Please provide direct links to spec and srpm here.

sorry. here:

srcrpm: http://srcrepo.sanaldiyar.com/pam_ldap2krb-0.1-1.el6.src.rpm
spec: https://git.sanaldiyar.com/gitweb.cgi/pam_ldap2krb.git/blob_plain/HEAD:/pam_ldap2krb.spec

(In reply to Kazım SARIKAYA from comment #4)
> i fixed my spec file:
> 
> * comment group (i have my own repo for my servers and i use group keyword,
> however for fedora i can comment it )
> * commenting requires 
Commenting is not good way. please delete this lines.

About requires I'm not sure from start. Feel free re-check it.

i remove everything about group and required. 
from the fedora packaging wiki, they mention that using required is necessary if the version of the required package is important. for my package it is not important.

the locations of srcrpm and spec do not changed. 

here the koji builds:
f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6628211
rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6628236

* Tue Mar 11 2014 Kazım SARIKAYA <kazimsarikaya> - 0.1

There should be %{version}-%{release}, i.e. in you case now it should be 0.1-1

%post
/sbin/ldconfig
%postun
/sbin/ldconfig

Replace with %post -p /sbin/ldconfig
the same with postun.

That's all, how I can help you. Find sponsor :)

i fixed all of you recommended and release the v0.1 tag at my scm.

spec file:
https://git.sanaldiyar.com/gitweb.cgi/pam_ldap2krb.git/blob_plain/b1aa6a45aca6314e3f9e6f5053544d2745f1e2ee:/pam_ldap2krb.spec

srcrpm: 
http://srcrepo.sanaldiyar.com/pam_ldap2krb-0.1-1.el6.src.rpm

koji builds:
f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6628469
rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6628539

thanks for all your help.

spec file: https://git.sanaldiyar.com/raw/linux!pam_ldap2krb.git/b1aa6a45aca6314e3f9e6f5053544d2745f1e2ee/pam_ldap2krb.spec

> License:	GPLv3

https://www.gnu.org/licenses/gpl-faq.html#NoticeInSourceFile


> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig

These scriptlets are not needed, because the package does not store any shared libraries in runtime linker's search path. The PAM Modules are located within a private path.


%files
%doc README
%{_sysconfdir}/pam_ldap2krb.conf

These two apply here:

  https://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files
  https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

* I added license info to source file
* delete post and postun scripts
* add copying to %doc
* add %config at begining of config file line

spec: http://projects.sanaldiyar.com/data/pam_ldap2krb/pam_ldap2krb.spec
srpm: http://projects.sanaldiyar.com/data/pam_ldap2krb/pam_ldap2krb-0.1-1.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6702421

guidelines were updated, so notes:
* Use %license LICENSE
* use %make_build instead of make %{?_smp_mflags}
* Add BuildRequires: gcc

What's your FAS username?

ping?

i stopped development of this package.