Bug 1075292

host info:
# uname -r && rpm -q qemu-kvm-rhev
3.10.0-100.el7.x86_64
qemu-kvm-rhev-1.5.3-50.el7.x86_64
guest info:
win7 64bit
qemu-ga-win-7.0-7
virtio-win-prewhql-0.1-74 

Result:
# nc -U /tmp/qga.sock
{"execute": "guest-ping"}
{"return": {}}
{ "execute": "system_reboot"}
{"error": {"desc": "The command system_reboot has not been found"}}

{"execute":"guest-suspend-"}
{"error": {"desc": "The command guest-suspend- has not been found"}}

{"execute":"guest-suspend-hybrid"}
{"error": {"desc": "this feature or command is not currently supported"}}

{"execute":"guest-s"}
{"error": {"desc": "The command guest-s has not been found"}}

Expected results:
# nc -U /tmp/qga.sock
{"execute":"guest-suspend-"}
{"error": {****"class"****: "CommandNotFound", "desc": "The command guest-suspend- has not been found", ****"data"****: {"name": "guest-suspend-"}}}
{"execute":"guest-suspend-hybrid"}
{"error": {****"class"****: "Unsupported", "desc": "this feature or command is not currently supported", ****"data"****: {}}}
{"execute":"guest-s"}
{"error": {****"class"****: "CommandNotFound", "desc": "The command guest-s has not been found", ****"data"****: {"name": "guest-s"}}}

Hi Yan,

Re-tested with qemu-ga-win-7.4.5-1 / qemu-kvm-rhev-2.9.0-1

1 { "execute": "system_reboot"}
{"error": {"class": "CommandNotFound", "desc": "The command system_reboot has not been found"}}

2 {"execute":"guest-suspend-"}
{"error": {"class": "CommandNotFound", "desc": "The command guest-suspend- has not been found"}}

3 {"execute":"guest-suspend-hybrid"}
{"error": {"class": "CommandDisabled", "desc": "The command guest-suspend-hybrid has been disabled for this instance"}}

4 {"execute":"guest-s"}
{"error": {"class": "CommandNotFound", "desc": "The command guest-s has not been found"}}

compare with expected results in comment#2
# nc -U /tmp/qga.sock
{"execute":"guest-suspend-"}
{"error": {"class": "CommandNotFound", "desc": "The command guest-suspend- has not been found", "data": {"name": "guest-suspend-"}}}
{"execute":"guest-suspend-hybrid"}
{"error": {"class": "Unsupported", "desc": "this feature or command is not currently supported", "data": {}}}
{"execute":"guest-s"}
{"error": {"class": "CommandNotFound", "desc": "The command guest-s has not been found", "data": {"name": "guest-s"}}}


1 About the 1st,2nd,4th, there is no ""data": {"name": "guest-s"}}}" for these commands.
2 About 3rd command , the result is not {"execute":"guest-suspend-hybrid"}
{"error": {"class": "Unsupported", "desc": "this feature or command is not currently supported", "data": {}}} , but similar with it, and also no ""data": {}}}"

Is that by design for the 1 and 2 concerns ? or it is still a issue?

Thanks
Yu Wang

(In reply to Yu Wang from comment #6)
> Hi Yan,
> 
> Re-tested with qemu-ga-win-7.4.5-1 / qemu-kvm-rhev-2.9.0-1
> 
> 1 { "execute": "system_reboot"}
> {"error": {"class": "CommandNotFound", "desc": "The command system_reboot
> has not been found"}}
> 
> 2 {"execute":"guest-suspend-"}
> {"error": {"class": "CommandNotFound", "desc": "The command guest-suspend-
> has not been found"}}
> 
> 3 {"execute":"guest-suspend-hybrid"}
> {"error": {"class": "CommandDisabled", "desc": "The command
> guest-suspend-hybrid has been disabled for this instance"}}
> 
> 4 {"execute":"guest-s"}
> {"error": {"class": "CommandNotFound", "desc": "The command guest-s has not
> been found"}}
> 
> compare with expected results in comment#2
> # nc -U /tmp/qga.sock
> {"execute":"guest-suspend-"}
> {"error": {"class": "CommandNotFound", "desc": "The command guest-suspend-
> has not been found", "data": {"name": "guest-suspend-"}}}
> {"execute":"guest-suspend-hybrid"}
> {"error": {"class": "Unsupported", "desc": "this feature or command is not
> currently supported", "data": {}}}
> {"execute":"guest-s"}
> {"error": {"class": "CommandNotFound", "desc": "The command guest-s has not
> been found", "data": {"name": "guest-s"}}}
> 
> 
> 1 About the 1st,2nd,4th, there is no ""data": {"name": "guest-s"}}}" for
> these commands.
> 2 About 3rd command , the result is not {"execute":"guest-suspend-hybrid"}
> {"error": {"class": "Unsupported", "desc": "this feature or command is not
> currently supported", "data": {}}} , but similar with it, and also no
> ""data": {}}}"
> 
> Is that by design for the 1 and 2 concerns ? or it is still a issue?
> 
> Thanks
> Yu Wang
The disabled message appears because of the earlier patch which marks this command as unsupported.

For data field the difference is because of the differences between the downstream and upstream repos in the qapi and error handling.

Thanks Yan,s reply,

So this bug has been fixed according to comment#6 and comment#7.
Change status to verified.


Thank
Yu Wang

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2341