Bug 1075506

Summary:	Dict leak in quota_lookup when quota is disabled
Product:	[Community] GlusterFS	Reporter:	vpshastry <vshastry>
Component:	quota	Assignee:	Raghavendra G <rgowdapp>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	gluster-bugs, nsathyan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.5.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-17 12:29:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description vpshastry 2014-03-12 10:02:37 UTC

Description of problem:
On every lookup quota takes a reference on the dict passed in the arguments but doesn't free if the quota is disabled.

Version-Release number of selected component (if applicable):


How reproducible:
Always.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-03-12 10:04:41 UTC

REVIEW: http://review.gluster.org/7227 (features/quota: fix the dict leak when quota is off) posted (#1) for review on master by Varun Shastry (vshastry)

Comment 2 Anand Avati 2014-03-12 18:06:30 UTC

COMMIT: http://review.gluster.org/7227 committed in master by Vijay Bellur (vbellur) 
------
commit 0ddd69a60e49f1335ed29a8225e31d24c836083a
Author: Varun Shastry <vshastry>
Date:   Wed Mar 12 15:22:14 2014 +0530

    features/quota: fix the dict leak when quota is off
    
    Change-Id: Iafe0c5104e38a1e34de1f2c2a19682178eb60e11
    BUG: 1075506
    Signed-off-by: Varun Shastry <vshastry>
    Reviewed-on: http://review.gluster.org/7227
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Anand Avati 2014-03-13 05:32:59 UTC

REVIEW: http://review.gluster.org/7233 (features/quota: fix the dict leak when quota is off) posted (#1) for review on release-3.5 by Varun Shastry (vshastry)

Comment 4 Anand Avati 2014-03-15 12:47:16 UTC

COMMIT: http://review.gluster.org/7233 committed in release-3.5 by Vijay Bellur (vbellur) 
------
commit 67bf41cd0a9318a26c18f033ce4d745a8c5a977e
Author: Varun Shastry <vshastry>
Date:   Wed Mar 12 15:22:14 2014 +0530

    features/quota: fix the dict leak when quota is off
    
    Change-Id: I15036da90e96b69858eac5a19bd438df3bd8cc53
    BUG: 1075506
    Signed-off-by: Varun Shastry <vshastry>
    Reviewed-on: http://review.gluster.org/7233
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 5 Niels de Vos 2014-04-17 12:29:40 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user