Bug 1075601 (ghc-exceptions)
| Summary: | Review Request: ghc-exceptions - Extensible optionally-pure exceptions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rick Elrod <relrod> |
| Component: | Package Review | Assignee: | Jens Petersen <petersen> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | haskell-devel, package-review |
| Target Milestone: | --- | Flags: | petersen:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ghc-exceptions-0.6.1-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-05-21 23:25:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 999011, 1074898, 1091216 | ||
|
Description
Rick Elrod
2014-03-12 13:00:20 UTC
Latest is now 0.5 Ah, doesn't depend on transformers-compat. :) Updated. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6779898 Spec URL: http://codeblock.fedorapeople.org/packages/ghc-exceptions/ghc-exceptions.spec SRPM URL: http://codeblock.fedorapeople.org/packages/ghc-exceptions/ghc-exceptions-0.5-1.fc20.src.rpm Looks fine
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 5 files have unknown license. Detailed output of
licensecheck in /home/petersen/pkgreview/1075601-ghc-
exceptions/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 307200 bytes in 22 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[-]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: ghc-exceptions-0.5-1.fc21.x86_64.rpm
ghc-exceptions-devel-0.5-1.fc21.x86_64.rpm
ghc-exceptions-0.5-1.fc21.src.rpm
ghc-exceptions.x86_64: W: incoherent-version-in-changelog 0.5 ['0.5-1.fc21', '0.5-1']
ghc-exceptions.src: W: strange-permission exceptions-0.5.tar.gz 0600L
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
These two will be fixed soon in cabal-rpm-0.8.11.
Rpmlint (installed packages)
----------------------------
# rpmlint ghc-exceptions ghc-exceptions-devel
ghc-exceptions.x86_64: W: incoherent-version-in-changelog 0.5 ['0.5-1.fc21', '0.5-1']
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'
Requires
--------
ghc-exceptions (rpmlib, GLIBC filtered):
ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57)
ghc(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b)
ghc(transformers-0.3.0.0-387c76a892254b0b8fe4d66f4780ad17)
libHSbase-4.6.0.1-ghc7.6.3.so()(64bit)
libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit)
libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit)
libHSmtl-2.1.2-ghc7.6.3.so()(64bit)
libHStransformers-0.3.0.0-ghc7.6.3.so()(64bit)
libc.so.6()(64bit)
libgmp.so.10()(64bit)
rtld(GNU_HASH)
ghc-exceptions-devel (rpmlib, GLIBC filtered):
/bin/sh
ghc(exceptions-0.5-44dc6c4284f996ee8cafe79a9229dfdd)
ghc-compiler
ghc-devel(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57)
ghc-devel(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b)
ghc-devel(transformers-0.3.0.0-387c76a892254b0b8fe4d66f4780ad17)
ghc-exceptions(x86-64)
Provides
--------
ghc-exceptions:
ghc(exceptions-0.5-44dc6c4284f996ee8cafe79a9229dfdd)
ghc-exceptions
ghc-exceptions(x86-64)
libHSexceptions-0.5-ghc7.6.3.so()(64bit)
ghc-exceptions-devel:
ghc-devel(exceptions-0.5-44dc6c4284f996ee8cafe79a9229dfdd)
ghc-exceptions-devel
ghc-exceptions-devel(x86-64)
ghc-exceptions-static
Unversioned so-files
--------------------
ghc-exceptions: /usr/lib64/ghc-7.6.3/exceptions-0.5/libHSexceptions-0.5-ghc7.6.3.so
Source checksums
----------------
http://hackage.haskell.org/package/exceptions-0.5/exceptions-0.5.tar.gz :
CHECKSUM(SHA256) this package : b1fbb73cc6bd6cd4f66f26817fdcc24da56d75cf885c84fd86460e715dbc2f51
CHECKSUM(SHA256) upstream package : b1fbb73cc6bd6cd4f66f26817fdcc24da56d75cf885c84fd86460e715dbc2f51
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1075601
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Haskell, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Package APPROVED
New Package SCM Request ======================= Package Name: ghc-exceptions Short Description: Extensible optionally-pure exceptions Owners: codeblock petersen Branches: f19 f20 epel7 InitialCC: haskell-sig Git done (by process-git-requests). ghc-exceptions-0.6.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-exceptions-0.6.1-1.fc20 ghc-exceptions-0.6.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ghc-exceptions-0.6.1-1.fc19 ghc-exceptions-0.6.1-1.fc20 has been pushed to the Fedora 20 testing repository. ghc-exceptions-0.6.1-1.fc19 has been pushed to the Fedora 19 stable repository. ghc-exceptions-0.6.1-1.fc20 has been pushed to the Fedora 20 stable repository. ghc-exceptions-0.6.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-exceptions-0.6.1-1.el7 ghc-exceptions-0.6.1-1.el7, ghc-ghc-mtl-1.2.1.0-1.el7, ghc-hint-0.4.2.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |