Bug 1076119
| Summary: | PKG: Enable tests in %check | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Todorov <atodorov> | ||||||
| Component: | systemd | Assignee: | systemd-maint | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | johannbg, jsynacek, lnykryn, msekleta, plautrba, systemd-maint, vpavlin, zbyszek | ||||||
| Target Milestone: | --- | Keywords: | Patch | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | systemd-219-3.fc22 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-02-18 21:33:10 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Unfortunately 'make check' is rather fragile and doesn't pass in mock. http://kojipkgs.fedoraproject.org//work/tasks/5499/6635499/build.log I think it'd be great to enable tests, but they should be made more robust (by applying patches upstream) first. I think it has something to do with D-Bus but I need to check. Is there any way we can get more logs from this build job? (e.g. test-suite.log if possible). Some test suites make it possible to print to stdout/stderr instead of a log file but I'm not sure about systemd's one. Created attachment 875395 [details]
Patch with VERBOSE=1
This should cause all errors to be printed to stderr/stdout.
From ./src/libsystemd/sd-bus/test-bus-chat.c
547 r = server_init(&bus);
548 if (r < 0) {
549 log_info("Failed to connect to bus, skipping tests.");
550 return EXIT_TEST_SKIP;
551 }
For some reason this succeeds on the build system but then the rest fails. On my test system I stopped DBus and this test was skipped instead of failing.
Can you apply updated patch so we can see what breaks and where? Thanks.
Here you go: http://koji.fedoraproject.org/koji/taskinfo?taskID=6640577. http://kojipkgs.fedoraproject.org//work/tasks/579/6640579/build.log has the details. It looks like something that should be fixed... BTW, you can build arbitrary scratch packages in koji without any privileges. (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > > http://kojipkgs.fedoraproject.org//work/tasks/579/6640579/build.log has the > details. It looks like something that should be fixed... > Yeah, looks like these two test cases are not properly handling the fact that they can't open the bus. They should be skipped not fail. However this goes beyond my powers. Do you want a separate bug reported for it, or you will fix it here ? Here's enough. Down to one failure: http://koji.fedoraproject.org/koji/taskinfo?taskID=7841513. There have been a few fixes recently regarding the tests: http://cgit.freedesktop.org/systemd/systemd/commit/?id=0eb3cc88504b5d8f740764047ac5162b67992386 http://cgit.freedesktop.org/systemd/systemd/commit/?id=536bfdab4cca38916ec8b112a6f80b0c068cc806 Perhaps they help? Tests still fail with 218. We should check again with 219. |
Created attachment 874027 [details] PATCH Description of problem: Just make check in %check Version-Release number of selected component (if applicable): systemd-211-1.fc21.src.rpm