Bug 1076976

New version with some corrections (LICENSE in the main package, dependencies):

Spec URL: http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-1b/rubygem-settingslogic.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-1b/rubygem-settingslogic-2.0.9-1.fc21.src.rpm

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6661369

Spec URL: http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-2/rubygem-settingslogic.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-2/rubygem-settingslogic-2.0.9-2.fc21.src.rpm

koji build: http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-2/rubygem-settingslogic-2.0.9-2.fc21.src.rpm

* Update BR/R for EPEL and Fedora >= 21

Spec URL: http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-2b/rubygem-settingslogic.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-2b/rubygem-settingslogic-2.0.9-2.fc22.src.rpm

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7200456

* Sun Jul 27 2014 František Dvořák <valtri.cz> - 2.0.9-2
- Update BR/R for EPEL and Fedora >= 20
- Remove development files before build
- Run tests inside %%{gem_instdir}

> BuildRequires:  rubygem(rspec)
> BuildRequires:  rubygem(rspec-core)

Requiring rspec-core here is redundant as its a dependency of rspec.

> # Remove developer-only files.
> for f in .gitignore Gemfile Gemfile.lock README.rdoc Rakefile; do

You sure can remove files used only for development, but README.rdoc is part of the documentation and as such should be placed in -doc subpackage and marked as %doc.

(In reply to Josef Stribny from comment #4)
> > BuildRequires:  rubygem(rspec)
> > BuildRequires:  rubygem(rspec-core)
> 
> Requiring rspec-core here is redundant as its a dependency of rspec.
> 

Yes, it is, except EPEL6. Moved rspec-core BR into sl6 macro block.

(and there will be needed to disable checks, if adding to EPEL7 branch - there is no rubygem(rspec-core) yet)


> > # Remove developer-only files.
> > for f in .gitignore Gemfile Gemfile.lock README.rdoc Rakefile; do
> 
> You sure can remove files used only for development, but README.rdoc is part
> of the documentation and as such should be placed in -doc subpackage and
> marked as %doc.

Didn't catch that, thanks.


Spec URL: http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-3/rubygem-settingslogic.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-3/rubygem-settingslogic-2.0.9-3.fc22.src.rpm

* Mon Jul 28 2014 František Dvořák <valtri.cz> - 2.0.9-3
- Added README.rdoc

> Yes, it is, except EPEL6. Moved rspec-core BR into sl6 macro block.

Try not to get lost in all those macros. Sometimes it's better to have different specs in more branches as the specs with a lot of conditionals cannot be easily upgraded by automatic scripts/tools and might be difficult for packagers doing OS wide fixes to deal with. But that's just up to you.

As this gem doesn't have any C extension I would probably remove the gem2rpm comment as misleading. Otherwise the fixes has been made, the package builds, installs, runs ==> APPROVING.

(In reply to Josef Stribny from comment #6)
> > Yes, it is, except EPEL6. Moved rspec-core BR into sl6 macro block.
> 
> Try not to get lost in all those macros. Sometimes it's better to have
> different specs in more branches as the specs with a lot of conditionals
> cannot be easily upgraded by automatic scripts/tools and might be difficult
> for packagers doing OS wide fixes to deal with. But that's just up to you.
> 

True, I've already though about separating at least the EPEL6 changes... I'll probably throw all the differences to the branches, there will be also the %check exception for EPEL7.

> As this gem doesn't have any C extension I would probably remove the gem2rpm
> comment as misleading. Otherwise the fixes has been made, the package
> builds, installs, runs ==> APPROVING.

OK. Thanks!

New Package SCM Request
=======================
Package Name: rubygem-settingslogic
Short Description: Simple settings solution for Ruby
Upstream URL: https://github.com/binarylogic/settingslogic
Owners: valtri
Branches: f19 f20 f21 el6 epel7
InitialCC:

Git done (by process-git-requests).

rubygem-settingslogic-2.0.9-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/rubygem-settingslogic-2.0.9-3.fc20

rubygem-settingslogic-2.0.9-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rubygem-settingslogic-2.0.9-3.fc19

rubygem-settingslogic-2.0.9-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/rubygem-settingslogic-2.0.9-3.el6

rubygem-settingslogic-2.0.9-3.fc20 has been pushed to the Fedora 20 testing repository.

rubygem-settingslogic-2.0.9-3.fc19 has been pushed to the Fedora 19 stable repository.

rubygem-settingslogic-2.0.9-3.fc20 has been pushed to the Fedora 20 stable repository.

rubygem-settingslogic-2.0.9-3.el6 has been pushed to the Fedora EPEL 6 stable repository.