Bug 1077283

Summary: [RHEVM] [neutron integration] cannot use linux bridge if ovs is not installed
Product: Red Hat Enterprise Virtualization Manager Reporter: Martin Pavlik <mpavlik>
Component: vdsmAssignee: Moti Asayag <masayag>
Status: CLOSED ERRATA QA Contact: Martin Pavlik <mpavlik>
Severity: high Docs Contact:
Priority: high    
Version: 3.4.0CC: acathrow, bazulay, danken, gklein, iheim, knesenko, lbopf, lpeer, masayag, mgoldboi, mpavlik, myakove, nyechiel, yeylon
Target Milestone: ---Keywords: Triaged
Target Release: 3.4.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: network
Fixed In Version: av5 Doc Type: Bug Fix
Doc Text:
Previously, a virtual machine with an imported network from external neutron provider (specifically Linux Bridge as the Networking Plugin) failed to run without 'ovs-vsctl' installed. Now, VDSM hook recognizes that Linux Bridge does not require 'ovs-vsctl' to run, and the virtual machine starts up.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-09 13:29:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1090946    
Attachments:
Description Flags
log_collector
none
screenshot 1 none

Description Martin Pavlik 2014-03-17 16:05:08 UTC
Created attachment 875561 [details]
log_collector

Description of problem:
I have external neutron provider with Networking Plugin = Linux Bridge
I've successfully imported network form neutron and attached it to VM.
When trying to run VM I get 
Failed to run VM VM1 on Host dell-05.
VM VM1 is down. Exit message: .

This happens because vdsm hook /usr/libexec/vdsm/hooks/before_device_create/50_openstacknet

is looking for ovs-vsctl

it should not look for ovs* when I am using linux bridge

Version-Release number of selected component (if applicable):
Red Hat Enterprise Virtualization Manager Version: 3.4.0-0.5.master.el6ev 

How reproducible:
100%

Steps to Reproduce:
1. Add external neutron provider with Networking Plugin = Linux Bridge
2. Import a network from Neutron
3. Create VM with the network attached
4. Start the VM

Actual results:
VM start fails because vdsm hook is looking for ovs-vsctl, while I am using linux bridge

Expected results:
VM starts

Additional info:

Thread-111::DEBUG::2014-03-17 16:43:24,401::utils::662::root::(execCmd) FAILED: <err> = 'Traceback (most recent call last):\n  File "/usr/libexec/vdsm/hooks/before_device_create/50_openstacknet", line 40, in <module>\n    from openstacknet_utils import DUMMY_BRIDGE\n  File "/usr/libexec/vdsm/hooks/before_device_create/openstacknet_utils.py", line 26, in <module>\n    \'/usr/bin/ovs-vsctl\').cmd\n  File "/usr/lib64/python2.6/site-packages/vdsm/utils.py", line 947, in cmd\n    os.strerror(os.errno.ENOENT) + \': \' + self.name)\nOSError: [Errno 2] No such file or directory: ovs-vsctl\n'; <rc> = 1

Comment 1 Martin Pavlik 2014-03-17 16:07:05 UTC
Created attachment 875562 [details]
screenshot 1

Comment 2 Dan Kenigsberg 2014-03-19 11:37:12 UTC
Martin, would you verify the suggested code?

Comment 3 Martin Pavlik 2014-03-19 14:23:50 UTC
code verified see comments in gerrit

Comment 6 Martin Pavlik 2014-03-26 16:31:56 UTC
works in av5

Comment 7 errata-xmlrpc 2014-06-09 13:29:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0504.html