Bug 107781

Summary:	hardcoding red hat in spec
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	esound	Assignee:	Havoc Pennington <hp>
Status:	CLOSED RAWHIDE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	wtogami
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2004-04-14 02:53:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom "spot" Callaway 2003-10-22 21:25:01 UTC

In the esound spec, this is the second line:

%define __os_install_post  /usr/lib/rpm/redhat/brp-compress

...isn't this always done?

This breaks aurora, or specifically, anything that has a different vendor dir
than /usr/lib/rpm/redhat (aurora has /usr/lib/rpm/aurora).

When this line is removed, during rpm creation, it is run as:

/usr/lib/rpm/brp-compress

The only difference between these two scripts is:

--- /usr/lib/rpm/redhat/brp-compress    2003-09-17 07:36:32.000000000 -0500
+++ /usr/lib/rpm/brp-compress   2003-07-17 21:46:36.000000000 -0500
@@ -8,7 +8,7 @@
 cd $RPM_BUILD_ROOT
  
 # Compress man pages
-COMPRESS="gzip -9 -n"
+COMPRESS="gzip -9"
 COMPRESS_EXT=.gz
  
 for d in ./usr/man/man* ./usr/man/*/man* ./usr/info \

... and -n is the default, so they're really identical.

Suggestion:

Change the line to reference /usr/lib/rpm/brp-compress, or omit it altogether.

Comment 1 Warren Togami 2004-04-14 02:53:39 UTC

After some discussion with notting about this...
1) It was added on Aug 21 2002 by sopwith to "Fix some stupid bugs".
2) The top line looks wrong to me, while the bottom line does nothing.

So I removed both.  Please test -2 when it hits rawhide to make sure
this does not break anything.