Bug 1077956
Summary: | Review Request: perl-Image-SubImageFind - Perl extension for locating a sub-image within an image | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Dick <ddick> |
Component: | Package Review | Assignee: | Petr Šabata <psabata> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, psabata |
Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Image-SubImageFind-0.03-1.el6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-03-31 02:10:05 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
David Dick
2014-03-19 00:09:24 UTC
FIX: BR perl(Exporter), lib/Image/SubImageFind.pm:24, loaded via use_ok() TODO: I think line 45 is not needed, not even on EPEL. FIX: This uses some code from http://werner.yellowcouch.org/Papers/subimg/ in DWVB.cpp. This could probably be considered a derived work and should include the original license in the License tag ("GPLv2+ and Copyright only", I'd say). What do you think? Again, I haven't tried building without those but I don't see any ImageMagick-devel header files used anywhere. Also, even those glibc-devel is not on the exceptions list, I think some C library, in whatever form, will always be available given that a compiler is. (In reply to Petr Šabata from comment #2) > FIX: BR perl(Exporter), lib/Image/SubImageFind.pm:24, loaded via use_ok() Done. > TODO: I think line 45 is not needed, not even on EPEL. Done. > FIX: This uses some code from http://werner.yellowcouch.org/Papers/subimg/ > in DWVB.cpp. This could probably be considered a derived work and should > include the original license in the License tag ("GPLv2+ and Copyright > only", I'd say). What do you think? I can't find any reference to an actual license for this code at all. I've sent an email to werner asking for a clarification of the license terms. > Again, I haven't tried building without those but I don't see any > ImageMagick-devel header files used anywhere. Also, even those glibc-devel > is not on the exceptions list, I think some C library, in whatever form, > will always be available given that a compiler is. Agreed. Spec and SRPMs have been updated, but are waiting for a license clarification from werner Werner (werner) has updated the following url to be licensed as GPLv2 http://werner.yellowcouch.org/Papers/subimg/subimg.c++ Therefore the license terms for the spec are correct and are waiting for approval. That was fast :) Yes, I believe this is correct but "GPLv2 and GPLv2+" would be even better (again, given the headers in the various source files in the package). Approving. New Package SCM Request ======================= Package Name: perl-Image-SubImageFind Short Description: Perl extension for locating a sub-image within an image Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig Git done (by process-git-requests). perl-Image-SubImageFind-0.03-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Image-SubImageFind-0.03-1.el6 perl-Image-SubImageFind-0.03-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Image-SubImageFind-0.03-1.fc20 perl-Image-SubImageFind-0.03-1.el6 has been pushed to the Fedora EPEL 6 testing repository. perl-Image-SubImageFind-0.03-1.fc20 has been pushed to the Fedora 20 stable repository. perl-Image-SubImageFind-0.03-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |