Bug 1078068

Summary:	dist-geo-rep: Python backtrace seen in geo-rep logs "ValueError: signal only works in main thread"
Product:	[Community] GlusterFS	Reporter:	Aravinda VK <avishwan>
Component:	geo-replication	Assignee:	Aravinda VK <avishwan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	pre-release	CC:	aavati, asrivast, avishwan, csaba, fdacunha, fharshav, gluster-bugs, nsathyan, pmutha, ssamanta, vbhat, vgaikwad, vkoppad, vumrao
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.5.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1044420	Environment:
Last Closed:	2014-04-17 12:29:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1044420, 1126354
Bug Blocks:

Comment 1 Anand Avati 2014-03-19 06:42:19 UTC

REVIEW: http://review.gluster.org/7294 (geo-rep: Fix ValueError - signal only works in main thread) posted (#1) for review on master by Aravinda VK (avishwan)

Comment 2 Anand Avati 2014-03-21 04:34:33 UTC

REVIEW: http://review.gluster.org/7294 (geo-rep: Fix ValueError - signal only works in main thread) posted (#2) for review on master by Aravinda VK (avishwan)

Comment 3 Anand Avati 2014-03-21 06:26:10 UTC

COMMIT: http://review.gluster.org/7294 committed in master by Vijay Bellur (vbellur) 
------
commit 3aeb95cfd072e06ed9dfbbb9249837da58c2e56a
Author: Aravinda VK <avishwan>
Date:   Wed Mar 19 12:00:44 2014 +0530

    geo-rep: Fix ValueError - signal only works in main thread
    
    When a worker process not confirmed within 60 seconds of start
    then monitor thread was terminated instead of stopping and restarting
    the worker thread.
    Before terminate monitor thread tries to add a signal handler for
    SIGTERM to cleanup the stuff before terminate. Signal handling will
    not work inside thread, so ValueError was raised.
    
    This patch will not terminate monitor thread, instead only kills and
    restarts the worker.
    
    Change-Id: I14df26c0cc3097af29293c81536c13b86075e28f
    BUG: 1078068
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/7294
    Reviewed-by: Venky Shankar <vshankar>
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Vijay Bellur <vbellur>

Comment 4 Anand Avati 2014-03-21 10:41:58 UTC

REVIEW: http://review.gluster.org/7313 (geo-rep: Fix ValueError - signal only works in main thread) posted (#1) for review on release-3.5 by Aravinda VK (avishwan)

Comment 5 Anand Avati 2014-03-24 17:30:41 UTC

COMMIT: http://review.gluster.org/7313 committed in release-3.5 by Vijay Bellur (vbellur) 
------
commit 853a90f9d7399e4afdb685946a809e9dd30a1b98
Author: Aravinda VK <avishwan>
Date:   Wed Mar 19 12:00:44 2014 +0530

    geo-rep: Fix ValueError - signal only works in main thread
    
    When a worker process not confirmed within 60 seconds of start
    then monitor thread was terminated instead of stopping and restarting
    the worker thread.
    Before terminate monitor thread tries to add a signal handler for
    SIGTERM to cleanup the stuff before terminate. Signal handling will
    not work inside thread, so ValueError was raised.
    
    This patch will not terminate monitor thread, instead only kills and
    restarts the worker.
    
    BUG: 1078068
    Change-Id: Icf0df7ef492da636d0d20e42750747e404d897df
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/7294
    Reviewed-on: http://review.gluster.org/7313
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 6 Niels de Vos 2014-04-17 12:29:46 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user