Bug 1078284

Summary:	Need later puppet-neutron
Product:	Red Hat OpenStack	Reporter:	Steve Reichard <sreichar>
Component:	openstack-puppet-modules	Assignee:	Martin Magr <mmagr>
Status:	CLOSED ERRATA	QA Contact:	Ofer Blaut <oblaut>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.0	CC:	adarazs, aortega, mlopes, mmagr, morazi, nyechiel, oblaut, yeylon
Target Milestone:	z4	Keywords:	ZStream
Target Release:	4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-puppet-modules-2013.2-9.el6ost	Doc Type:	Bug Fix
Doc Text:	Previously, installing Cisco components with the puppet-neutron module would result in failure when creating the /etc/neutron/plugin.ini symbolic link. With this update, the issue has been corrected and the module is expected to complete successfully under these conditions.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-05-29 20:03:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1040649, 1104759

Description Steve Reichard 2014-03-19 14:28:49 UTC

Description of problem:

Working with Cisco we ran into an issue which Pradeep from Cisco says was address in the upstream.  
----

This is an issue with the upstream stack forge puppet-neutron. There is a
recent
Change to upstream manifests that added a symlink that isn¹t really needed
for
modern cisco plugin configuration and causes duplicate definition errors in
conjunction with ovs.

Here is the recent commit related to this:

https://github.com/stackforge/puppet-neutron/commit/4be69d2cdde185a241ecb34
361ab6a473191e975


For now as a workaround, just comment out lines 174-178 from
/usr/share/packstack/modules/neutron/manifests/plugins/cisco.pp


  #file {'/etc/neutron/plugin.ini':
  #  ensure  => link,
  #  target  => '/etc/neutron/plugins/cisco/cisco_plugins.ini',
  #  require => Package['neutron-plugin-cisco']
  #}


There is a pending upstream fix that should resolve this next week.

I¹ll let you know once the fix lands so you guys can pull the fix in.

~ Prad










Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Mike Orazi 2014-03-27 20:18:58 UTC

Returning this to A4 for further consideration/discussion.

Comment 3 Martin Magr 2014-03-28 10:03:02 UTC

The point of adding the bug to A5 was that to update the puppet-neutron
module we will need to first backport the noted pengding review to
stable/havana (if it's not already done) and then test installation with
updated module, because module updates tend to break stuff. Noted
workaround will be part of A4 o-p-m build of course. But unfortunately I
don't think we have resources to do the full update in A4 time frame.

Steve, it would also help if you would add url to 'pending upstream fix' to this bug.

Comment 4 Alvaro Lopez Ortega 2014-03-31 16:43:31 UTC

Moving it to A5. If we ended up being able to implement it upstream in the A4 timeframe we could move it back.

Comment 5 Steve Reichard 2014-04-02 12:37:05 UTC

Update from Pradeep:


Hi Steve:

The patch for that issue is still pending upstream. Reason for the delay
is that its part of a bigger patch.
I’ll see if we can break it up so we can get a fix for this symlink issue
sooner.

Here is link to the review: https://review.openstack.org/#/c/78550/

~ Pradeep

Comment 6 Steve Reichard 2014-04-02 14:22:56 UTC

Pradeep updated , he made a smaller patch covering this issue.  I am moving back to A4, if you feel comfortable pulling this smaller patch.  If not, understand and move back to A5.


----

Here is the patch I submitted upstream for this issue.

https://review.openstack.org/#/c/84728/


Its merged into havana now. You guys should be able to pull it down.

~ Pradeep

Comment 7 Martin Magr 2014-04-02 16:05:16 UTC

Workaround patch added in openstack-puppet-modules-2013.2-8.el6ost

Comment 8 Martin Magr 2014-04-03 13:32:38 UTC

Submitted pull request with update: https://github.com/redhat-openstack/openstack-puppet-modules/pull/9

Comment 13 Ofer Blaut 2014-04-27 13:28:14 UTC

Tested 

 rpm -q openstack-puppet-modules;
 
 openstack-puppet-modules-2013.2-9.el6ost.noarch

 tail -10 /usr/share/openstack-puppet/modules/neutron/manifests/plugins/cisco.pp 


  }

  # In RH, this link is used to start Neutron process but in Debian, it's used only
  # to manage database synchronization.
  ensure_resource('file', '/etc/neutron/plugin.ini', {
    ensure  => link,
    target  => '/etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini',
    require => Package['neutron-plugin-ovs']
  })
}


[root@puma33 bin]# tail -10  /usr/share/openstack-puppet/modules/neutron/manifests/plugins/ovs.pp
  }

  # In RH, this link is used to start Neutron process but in Debian, it's used only
  # to manage database synchronization.
  file {'/etc/neutron/plugin.ini':
    ensure  => link,
    target  => '/etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini',
    require => Package['neutron-plugin-ovs']
  }
}
[root@p

Comment 15 errata-xmlrpc 2014-05-29 20:03:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0577.html