Bug 1078327

*** Bug 1078336 has been marked as a duplicate of this bug. ***

Buildroot overrides have been created for the new dependency python-pyramid-mako.

looks like font is installed using this package. Generally fonts are packaged separately.

Paran, it is formatted as a font, but they are really icons used by css.  These icons, in particular:
http://getbootstrap.com/components/#glyphicons

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 16 files have unknown license. Detailed output of
     licensecheck in /home/mockbuild/review/github2fedmsg/licensecheck.txt

There is no copyright notice in any of the source files.

https://www.gnu.org/licenses/agpl-3.0.html#howto
"attach the following notices to the program. It is safest to attach them to the start of each source file to most effectively state the exclusion of warranty; and each file should have at least the "copyright" line and a pointer to where the full notice is found."

For the license tag to remain as AGPLv3+, then it must have the copyright notice somewhere that includes the "any later version" phrase.

Since you are the upstream author, this should be trivial to fix :)


[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files

Note that there is a glyphicons-halflings-fonts package already available in Fedora that you may use.


[x]: Rpmlint is run on all installed packages

github2fedmsg.noarch: W: spelling-error %description -l en_US brodcasts -> broadcasts, broadcast

Should be "broadcasts".


github2fedmsg.noarch: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon

I would prefer if you expanded to "web application" here, but it's up to you.


github2fedmsg.src: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish

I would prefer if you capitalized as per upstream "GitHub", but again up to you.



[!]: Package contains no bundled libraries without FPC exception.

All packages now have to comply with the new JavaScript and Web Assets guidelines. You'll need to open an FPC bundling exception ticket for the bundled Twitter Bootstrap. Since Twitter Bootstrap is not yet packaged for Fedora, and since there are many other packages that already bundle it, FPC will very likely allow an exception. (FPC recently allowed a blanket exception for jQuery until myself and T.C. finish packaging jQuery and its numerous BuildRequires.)

https://fedoraproject.org/wiki/Packaging:JavaScript
https://fedoraproject.org/wiki/Packaging:Web_Assets


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 16 files have unknown license. Detailed output of
     licensecheck in /home/mockbuild/review/github2fedmsg/licensecheck.txt
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: github2fedmsg-0.2.2-1.fc21.noarch.rpm
          github2fedmsg-0.2.2-1.fc21.src.rpm
github2fedmsg.noarch: W: spelling-error Summary(en_US) Pubsubhubbub -> Hubbub
github2fedmsg.noarch: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon
github2fedmsg.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish
github2fedmsg.noarch: W: spelling-error %description -l en_US brodcasts -> broadcasts, broadcast
github2fedmsg.noarch: W: spelling-error %description -l en_US velruse -> Severus, Russel
github2fedmsg.noarch: W: spelling-error %description -l en_US webhook -> web hook, web-hook, webfoot
github2fedmsg.noarch: W: no-manual-page-for-binary initialize_github2fedmsg_db
github2fedmsg.src: W: spelling-error Summary(en_US) Pubsubhubbub -> Hubbub
github2fedmsg.src: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon
github2fedmsg.src: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish
github2fedmsg.src: W: spelling-error %description -l en_US brodcasts -> broadcasts, broadcast
github2fedmsg.src: W: spelling-error %description -l en_US velruse -> Severus, Russel
github2fedmsg.src: W: spelling-error %description -l en_US webhook -> web hook, web-hook, webfoot
2 packages and 0 specfiles checked; 0 errors, 13 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint github2fedmsg
github2fedmsg.noarch: W: spelling-error Summary(en_US) Pubsubhubbub -> Hubbub
github2fedmsg.noarch: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon
github2fedmsg.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish
github2fedmsg.noarch: W: spelling-error %description -l en_US brodcasts -> broadcasts, broadcast
github2fedmsg.noarch: W: spelling-error %description -l en_US velruse -> Severus, Russel
github2fedmsg.noarch: W: spelling-error %description -l en_US webhook -> web hook, web-hook, webfoot
github2fedmsg.noarch: W: no-manual-page-for-binary initialize_github2fedmsg_db
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
# echo 'rpmlint-done:'



Requires
--------
github2fedmsg (rpmlib, GLIBC filtered):
    /usr/bin/python2
    fedmsg
    python(abi)
    python-alembic
    python-pyramid
    python-pyramid-mako
    python-pyramid-tm
    python-setuptools
    python-sqlalchemy
    python-transaction
    python-tw2-core
    python-velruse
    python-weberror
    python-zope-sqlalchemy



Provides
--------
github2fedmsg:
    github2fedmsg



Source checksums
----------------
http://pypi.python.org/packages/source/g/github2fedmsg/github2fedmsg-0.2.2.tar.gz :
  CHECKSUM(SHA256) this package     : bb4cb55fe97443cc168772f60bced20bbf48822e52954d3923d111a2328a87f8
  CHECKSUM(SHA256) upstream package : bb4cb55fe97443cc168772f60bced20bbf48822e52954d3923d111a2328a87f8


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -r -n ../github2fedmsg-0.2.2-1.fc20.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Bundling exception requested:  https://fedorahosted.org/fpc/ticket/428

New release addressing the issues you raised, Jamie:

- License headers
- Unbundled fonts
- rpmlint fixes

Spec URL: http://threebean.org/rpm/SPECS/github2fedmsg.spec
SRPM URL: http://threebean.org/rpm/SRPMS/github2fedmsg-0.2.4-1.fc20.src.rpm

Temporary bundling exception granted:  https://fedorahosted.org/fpc/ticket/428#comment:2

Latest upstream that includes forgotten templates:

Spec URL: http://threebean.org/rpm/SPECS/github2fedmsg.spec
SRPM URL: http://threebean.org/rpm/SRPMS/github2fedmsg-0.2.6-1.fc20.src.rpm

Latest upstream with some fixed links:

Spec URL: http://threebean.org/rpm/SPECS/github2fedmsg.spec
SRPM URL: http://threebean.org/rpm/SRPMS/github2fedmsg-0.2.7-1.fc20.src.rpm

Latest upstream with a rewrite of the subscription mechanism.  Requires users to commit to a less far-reaching oauth scope.

Spec URL: http://threebean.org/rpm/SPECS/github2fedmsg.spec
SRPM URL: http://threebean.org/rpm/SRPMS/github2fedmsg-0.3.0-1.fc20.src.rpm

Another upstream release with a bugfix to the handling of callback payloads.

Spec URL: http://threebean.org/rpm/SPECS/github2fedmsg.spec
SRPM URL: http://threebean.org/rpm/SRPMS/github2fedmsg-0.3.1-1.fc20.src.rpm

Very sorry Ralph for the delay :(

Thanks for the fixes!


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "AGPL (v3 or later)". Detailed output of licensecheck in
     /home/mockbuild/review/github2fedmsg/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: github2fedmsg-0.3.1-1.fc21.noarch.rpm
          github2fedmsg-0.3.1-1.fc21.src.rpm
github2fedmsg.noarch: W: spelling-error Summary(en_US) Pubsubhubbub -> Hubbub
github2fedmsg.noarch: W: spelling-error %description -l en_US velruse -> Severus, Russel
github2fedmsg.noarch: W: spelling-error %description -l en_US webhook -> web hook, web-hook, webfoot
github2fedmsg.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/github2fedmsg/static/bootstrap-3.1.1-fedora/fonts /usr/share/fonts/glyphicons-halflings
github2fedmsg.noarch: W: no-manual-page-for-binary initialize_github2fedmsg_db
github2fedmsg.src: W: spelling-error Summary(en_US) Pubsubhubbub -> Hubbub
github2fedmsg.src: W: spelling-error %description -l en_US velruse -> Severus, Russel
github2fedmsg.src: W: spelling-error %description -l en_US webhook -> web hook, web-hook, webfoot
2 packages and 0 specfiles checked; 0 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint github2fedmsg
github2fedmsg.noarch: W: spelling-error Summary(en_US) Pubsubhubbub -> Hubbub
github2fedmsg.noarch: W: spelling-error %description -l en_US velruse -> Severus, Russel
github2fedmsg.noarch: W: spelling-error %description -l en_US webhook -> web hook, web-hook, webfoot
github2fedmsg.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/github2fedmsg/static/bootstrap-3.1.1-fedora/fonts /usr/share/fonts/glyphicons-halflings
github2fedmsg.noarch: W: no-manual-page-for-binary initialize_github2fedmsg_db
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
# echo 'rpmlint-done:'



Requires
--------
github2fedmsg (rpmlib, GLIBC filtered):
    /usr/bin/python2
    fedmsg
    glyphicons-halflings-fonts
    python(abi)
    python-pyramid
    python-pyramid-mako
    python-pyramid-tm
    python-setuptools
    python-sqlalchemy
    python-transaction
    python-tw2-core
    python-velruse
    python-weberror
    python-zope-sqlalchemy



Provides
--------
github2fedmsg:
    github2fedmsg



Source checksums
----------------
http://pypi.python.org/packages/source/g/github2fedmsg/github2fedmsg-0.3.1.tar.gz :
  CHECKSUM(SHA256) this package     : dedf8df749d667f12b57bfae4fbb512efde7efa9c73e29b2e5ee8acb4b3f5410
  CHECKSUM(SHA256) upstream package : dedf8df749d667f12b57bfae4fbb512efde7efa9c73e29b2e5ee8acb4b3f5410


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -r -n github2fedmsg-0.3.1-1.fc20.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

You just need to add this:

  Provides: bundled(bootstrap)
  Provides: bundled(jquery)

See: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Packages_granted_temporary_exceptions

Assuming you add those provides, package approved!

Cool.  I'll add them before import.  Thanks Jamie!

No SCM request found.

New Package SCM Request
=======================
Package Name: github2fedmsg
Short Description: Pubsubhubbub app that rebroadcasts GH events over fedmsg
Upstream URL: https://github.com/fedora-infra/github2fedmsg
Owners: ralph
Branches: el6
InitialCC:

Git done (by process-git-requests).

Thanks all!

github2fedmsg-0.3.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/github2fedmsg-0.3.1-2.el6

Unbundling begun:  https://bugzilla.redhat.com/showdependencygraph.cgi?id=1115659&display=tree&rankdir=TB

github2fedmsg-0.3.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Package Change Request
======================
Package Name: github2fedmsg
New Branches: epel7
Owners: ralph

Git done (by process-git-requests).