Bug 1078949
| Summary: | Include highlight styles in cgit.css | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
| Component: | cgit | Assignee: | Todd Zullinger <tmz> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | kevin, tmz | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | cgit-0.10.1-2.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-06-02 17:31:14 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Ville Skyttä
2014-03-20 15:22:55 UTC
Created attachment 876915 [details]
Include highlight styles in cgit.css
Is there any solution we can come up with here that is upstreamable? Does the highlight style change per version? Or could we just hard code/include it? I'm not opposed to doing this, just would be nice if it was something upstream could do, and I don't think they would like build time generation... (In reply to Kevin Fenzi from comment #2) > Is there any solution we can come up with here that is upstreamable? Maybe, that's what I initially thought and looked into but ran out of time and interest. > Does the highlight style change per version? > Or could we just hard code/include it? It does change every now and then; the numerous commented out chunks of CSS in syntax-highlighting.sh are outputs from / examples for different source-highlight versions. I've posted to the upstream list to see how they might want to handle this. http://lists.zx2c4.com/pipermail/cgit/2014-April/002060.html Just a comment wrt "Some folks like to adjust the css that highlight uses" in your message: without including the CSS for highlight in cgit.css (or inline in the markup), enabling highlight is pretty much pointless as there's no highlighting/colorizing visible in browsers even if highlight did spend some cycles processing the source. Upstream solution would be nice, but frankly I don't see any problems in the approach I suggested for Fedora/EPEL and would suggest that applying it shouldn't wait too long for an upstream resolution. Yeah. If you want to just apply this for now, go for it... Or I can try and get to it in a few days. cgit-0.10.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/cgit-0.10.1-2.el6 Package cgit-0.10.1-2.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing cgit-0.10.1-2.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-1443/cgit-0.10.1-2.el6 then log in and leave karma (feedback). cgit-0.10.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |