Bug 1078950

Summary:	Review Request: perl-Test-Modern - Precision testing for modern perl
Product:	[Fedora] Fedora	Reporter:	Paul Howarth <paul>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test-Modern-0.005-1.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-15 15:45:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Paul Howarth 2014-03-20 15:24:45 UTC

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-Modern/branches/fedora/perl-Test-Modern.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-Modern/perl-Test-Modern-0.002-2.fc21.src.rpm

Description:
Test::Modern provides the best features of Test::More, Test::Fatal,
Test::Warnings, Test::API, Test::LongString, and Test::Deep, as well as ideas
from Test::Requires, Test::DescribeMe, Test::Moose, and Test::CleanNamespaces.

Test::Modern also automatically imposes strict and warnings on your script.

Fedora Account System Username: pghmcfc

Unfortunately Test::Modern is already too modern for EL-7 as the versions of Test::Deep and Try::Tiny there are too old.

Comment 1 Petr Šabata 2014-03-20 16:09:02 UTC

TODO: BR perl, perl-Test-Modern.spec:48
TODO: BR perl(base), t/06class-api-ok.t:26
TODO: You should run-require perl(Tiny::Role), perl(Moose::Util), and perl(Mouse::Util)

FIX: The CONTRIBUTING file states the following:

COPYRIGHT AND LICENCE
    Copyright (c) 2012-2013 by Toby Inkster.

    CONTRIBUTING.pod is licensed under the Creative Commons
    Attribution-ShareAlike 2.0 UK: England & Wales License. To view a copy
    of this license, visit
    <http://creativecommons.org/licenses/by-sa/2.0/uk/>.

Even though this is not `CONTIBUTING.pod', I think the author's intention is fairly clear and CC-BY-SA should be added to your License tag.  Still, contacting the author about the file name mismatch would be good.

Comment 2 Paul Howarth 2014-03-20 21:38:51 UTC

All issues addressed in -3:

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-Modern/branches/fedora/perl-Test-Modern.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-Modern/perl-Test-Modern-0.002-3.fc21.src.rpm

Comment 3 Petr Šabata 2014-03-21 11:54:19 UTC

Alright, looks good.
Approving.

Comment 4 Paul Howarth 2014-03-21 12:02:54 UTC

New Package SCM Request
=======================
Package Name: perl-Test-Modern
Short Description: Precision testing for modern perl
Owners: pghmcfc
Branches: f20
InitialCC: perl-sig

Thanks for the review Petr.

Comment 5 Gwyn Ciesla 2014-03-21 13:04:24 UTC

Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-03-21 14:57:11 UTC

perl-Test-Modern-0.002-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Test-Modern-0.002-3.fc20

Comment 7 Fedora Update System 2014-03-22 05:06:50 UTC

perl-Test-Modern-0.002-3.fc20 has been pushed to the Fedora 20 testing repository.

Comment 8 Fedora Update System 2014-03-31 02:11:44 UTC

perl-Test-Modern-0.005-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 9 Fedora Update System 2014-04-15 15:45:02 UTC

perl-Test-Modern-0.005-1.fc20 has been pushed to the Fedora 20 stable repository.