Bug 1078960

Summary:	Review Request: mino - A user friendly text editor for the Linux console/xterm
Product:	[Fedora] Fedora	Reporter:	Mohammed Isam <mohammed_isam1984>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DEFERRED	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jobernar, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-11 10:44:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mohammed Isam 2014-03-20 15:36:41 UTC

Spec URL: http://sites.google.com/site/mohammedisam2000/home/projects/mino.spec
SRPM URL: http://sites.google.com/site/mohammedisam2000/home/projects/mino-1.0-1.fc20.src.rpm
Description: Mino is a text file editor for use with the Linux console/xterm. The idea was to provide a text editor that is user friendly and easy to use (especially for those who are experienced with the GUI interface). Having accustomed to SHIFT selecting text, using CTRL-shortcut keys and so on makes it hard for a regular Joe to learn how to use other text based editor that need special syntaxes and hard (sometimes akward) commands that need memorizing. This is where mino comes to play. You don't need to learn any thing! Use it under Linux console or even the X system and editing configuration (and other text) files is just a breeze.
Fedora Account System Username: mohammedisam

Comment 1 Mohammed Isam 2014-03-20 15:39:44 UTC

*** Bug 1078103 has been marked as a duplicate of this bug. ***

Comment 2 Jon Bernard 2014-03-25 17:48:49 UTC

Package looks good, here are a few things that could be improved:

* Groups should be "Applications/Editors" and not "Editors"
* The Source0 URL gives 404 Not Found
* There are two spelling mistakes in the description:
  - 'syntaxes' should probably be 'syntax'
  - 'akward' should be 'awkward'

Comment 3 Christopher Meng 2014-03-26 08:47:26 UTC

(In reply to Jon Bernard from comment #2)
> Package looks good, here are a few things that could be improved:
> 
> * Groups should be "Applications/Editors" and not "Editors"

1. Group tag no longer needed as a MUST, in fact packager should remove it.

2. install with -p to preserve the timestamp.

3. I hope you can have a URL for your project, not just from google site.

Thanks.

Comment 4 Mohammed Isam 2014-03-26 10:58:01 UTC

1. Edited the spec file and updated the link.
2. Fixed the broken .tar.gz link.
3. Unfortunately currently this is my personal website this is why I am uploading my projects here.

Thanks

Comment 5 Michael Schwendt 2014-04-10 18:28:51 UTC

Please review the build.log for compiler warnings and fix the ones that are reason to be worried. E.g. format string related warnings and "array subscript is above array bounds".