Bug 1078994 (kde-plasma-milou)
Summary: | Review Request: kde-plasma-milou - Plasma applet for searching almost anything | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jeischma, jgrulich, kevin, package-review, rdieter |
Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
petersen: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-05-02 08:11:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 656997 |
Description
Daniel Vrátil
2014-03-20 17:39:31 UTC
1) libmilou.so should be versioned 2) license should be GPLv2+ and LGPLv2+, instead of separated by comma Updated to latest upstream snapshot (which includes libmilou SONAME) and fix the license issue. Spec URL: http://dvratil.fedorapeople.org/spec/milou.spec SRPM URL: http://dvratil.fedorapeople.org/spec/milou-0.1-0.1.20140408git.fc20.src.rpm Successful Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6718223 Output from rpmlint: Checking: milou-0.1-0.1.20140408git.fc21.x86_64.rpm milou-0.1-0.1.20140408git.fc21.src.rpm milou.x86_64: W: invalid-url URL: https://projects.kde.org/projects/kdereview/milou HTTP Error 500: Internal Server Error milou.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libmilou.so milou.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmilou.so.0.1 milou.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmilou.so.0.1 milou.src: W: invalid-url URL: https://projects.kde.org/projects/kdereview/milou HTTP Error 500: Internal Server Error milou.src:12: W: macro-in-comment %{version} milou.src:13: W: macro-in-comment %{version} milou.src:13: W: macro-in-comment %{snapshot} milou.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 12) milou.src: W: invalid-url Source0: milou-0.1.20140408git.tar.xz 2 packages and 0 specfiles checked; 2 errors, 8 warnings. I guess that relevant are only these: milou.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmilou.so.0.1 milou.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmilou.so.0.1 milou.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 12) Spec URL: http://dvratil.fedorapeople.org/spec/milou.spec SRPM URL: http://dvratil.fedorapeople.org/spec/milou-0.1-0.1.20140411git.fc20.src.rpm - Updates to latest git snapshot - Added %%post and %%postun sections - Fixed project Url - Fixed mixed-use-of-spaces-and-tabs and macro-in-comment 1) When updating git snapshots, you have to also increase release versions, so you should have 0.1-0.1.xxxxgit → 0.1-0.2.yyyygit and so on. 2) Why did you commented out all BR? Probably a mistake, it works when I uncomment them. Otherwise the package is good, just fix the mentioned issues before you upload the package to git. Thinking about this, do you think I should rename the package to kde-plasma-milou? It would probably be more consistent with our naming conventions in KDE. You are right, it should be definitely kde-plasma-milou. I think you can change the name in SCM request. New Package SCM Request ======================= Package Name: kde-plasma-milou Short Description: Plasma applet for searching almost anything Owners: dvratil Branches: f20 InitialCC: Requested package name kde-plasma-milou doesn't match bug summary milou, please correct. New Package SCM Request ======================= Package Name: kde-plasma-milou Short Description: Plasma applet for searching almost anything Owners: dvratil Branches: f20 InitialCC: jgrulich ltinkl rdieter kkofler Git done (by process-git-requests). |