Bug 1079640

Spec URL: http://scientific.zcu.cz/fedora/rubygem-json_spec-1.1.1-2/rubygem-json_spec.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-json_spec-1.1.1-2/rubygem-json_spec-1.1.1-2.fc21.src.rpm

koji build (for rawhide requires tag f21-ruby): http://koji.fedoraproject.org/koji/taskinfo?taskID=6769677

changes:
- No Requires since F21
- Remove skipping full cucumber tests for F21 (will be solved in #1054793)

Just a few notes from me:

* Don't use Rake to execute test suite
  - We typically don't use Rake to execute test suite, since it almost always
    needs some additional unnecessary dependencies.

* Execute the test suite in .%{gem_instdir}
  - Although there is more places where the test suite can be executed,
    execution of the test suite in '.' directory is the worst option, since
    it is the content of gem before repackaging. The best place IMO is the
    .%{gem_instdir}

* Don't use Bundler
  - Similarly to Rake, we trying to avoid Bundler. It typically downloads some
    external dependencies or doing another stuff which is more or less against
    what we are trying to achieve, i.e. using system dependencies.

* -doc sub package should not R: ruby(rubygems)
  - It always depends on the main package, so there is no need for any other
    dependencies.

* Keep the documentation in %{gem_instdir}
  - We typically keep the README as well as the LICENSE files on their original
    places. However we might disagree on this.

* Is the patching of .gitignore needed?
  - Not sure about this stuff. Why are you doing so? Why not %exclude it as you
    are doing with other files?

Thanks for the comments! Without rake the bundler is not needed anymore. And each point simplifies the packaging. :-)

New version:

Spec URL: http://scientific.zcu.cz/fedora/rubygem-json_spec-1.1.1-3/rubygem-json_spec.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-json_spec-1.1.1-3/rubygem-json_spec-1.1.1-3.fc21.src.rpm

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6920651

Spec URL: http://scientific.zcu.cz/fedora/rubygem-json_spec-1.1.2-1/rubygem-json_spec.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-json_spec-1.1.2-1/rubygem-json_spec-1.1.2-1.fc21.src.rpm

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7117071

* New upstream release 1.1.2
* Separated out <= F20 and <= EPEL7 stuff

Spec URL: http://scientific.zcu.cz/fedora/rubygem-json_spec-1.1.2-1b/rubygem-json_spec.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-json_spec-1.1.2-1b/rubygem-json_spec-1.1.2-1.fc22.src.rpm

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7211557

* removed ruby(release) BR
* removing developer-only files sooner in %prep (they won't be there during tests), %exclude only files needed for tests

I would personally put README, Rakefile and Gemfile into -doc subpackage, but this is only my preference. Issues mentioned by Vit has been addressed. Otherwise the spec looks sane, rpmlint doesn't complain, package builds, installs, runs ==> APPROVED.

OK, thanks! I will move the README to the -doc, if there is -doc subpackage already, it could better fit there.

New Package SCM Request
=======================
Package Name: rubygem-json_spec
Short Description: Easily handle JSON in RSpec and Cucumber
Upstream URL: https://github.com/collectiveidea/json_spec
Owners: valtri
Branches: f20 f21
InitialCC:

Git done (by process-git-requests).

rubygem-json_spec-1.1.2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/rubygem-json_spec-1.1.2-1.fc20

rubygem-json_spec-1.1.2-1.fc20 has been pushed to the Fedora 20 testing repository.

rubygem-json_spec-1.1.2-1.fc20 has been pushed to the Fedora 20 stable repository.