Bug 1079718 (perl-Catalyst-Plugin-Compress)
Summary: | Review Request: perl-Catalyst-Plugin-Compress - Compress Catalyst response | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Sven Nierlein <Sven.Nierlein> |
Component: | Package Review | Assignee: | David Dick <ddick> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | ddick, package-review, rc040203 |
Target Milestone: | --- | Flags: | ddick:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.005-4 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-06-05 18:37:01 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1069988 |
Description
Sven Nierlein
2014-03-23 13:02:39 UTC
Spec file update according to comments of related bugs and uploaded new files to: http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Compress.spec http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Compress-0.005-1.fc21.noarch.rpm Source RPM: http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Compress-0.005-1.fc21.src.rpm new spec file: http://nierlein.com/fedora/2014-04-21/perl-Catalyst-Plugin-Compress.spec the only thing i changed is the release number. Missing [MUSTFIX]: Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Sorry for the delay, i wanted to get through the review process with one module first and then work on the remaining review requests. So here is the updated spec file: http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-Compress.spec http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-Compress-0.005-3.fc21.src.rpm Hi Sven, The following BRs MUST be fixed. --- perl-Catalyst-Plugin-Compress.old 2014-05-20 23:51:55.000000000 +1000 +++ perl-Catalyst-Plugin-Compress.spec 2014-05-21 21:02:00.988340126 +1000 @@ -8,16 +8,28 @@ Source0: http://www.cpan.org/modules/by-module/Catalyst/Catalyst-Plugin-Compress-%{version}.tar.gz BuildArch: noarch BuildRequires: perl +BuildRequires: perl(Catalyst::Utils) +BuildRequires: perl(Config) +BuildRequires: perl(Cwd) +BuildRequires: perl(Fcntl) +BuildRequires: perl(File::Find) +BuildRequires: perl(File::Path) +BuildRequires: perl(File::Spec) +BuildRequires: perl(FindBin) +BuildRequires: perl(List::Util) BuildRequires: perl(Test::More) BuildRequires: perl(Catalyst::Runtime) >= 5.80001 BuildRequires: perl(Compress::Bzip2) >= 2 BuildRequires: perl(Compress::Zlib) BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(ExtUtils::MM_Unix) BuildRequires: perl(MRO::Compat) +BuildRequires: perl(strict) +BuildRequires: perl(vars) +BuildRequires: perl(warnings) Requires: perl(Catalyst::Runtime) >= 5.80001 Requires: perl(Compress::Bzip2) >= 2 Requires: perl(Compress::Zlib) -Requires: perl(MRO::Compat) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description The runtime "Requires: perl(MRO::Compat)" was removed as it is auto-detected. The other requirements cannot be auto-detected, so they were left. Once you apply these changes, this package should be good to go. Ok, thanks. I applied your patch and uploaded new files here: http://nierlein.com/fedora/2014-05-24/perl-Catalyst-Plugin-Compress.spec http://nierlein.com/fedora/2014-05-24/perl-Catalyst-Plugin-Compress-0.005-4.fc21.src.rpm koji builds ok at http://koji.fedoraproject.org/koji/taskinfo?taskID=6887280 License ok. Build/Requires ok. rpmlint is fine (incorrect spelling errors are the only output) pure perl library. no C deps fedora-review did not produce any errors/warnings package APPROVED! New Package SCM Request ======================= Package Name: perl-Catalyst-Plugin-Compress Short Description: Compress response Owners: sni Branches: f21 InitialCC: perl-sig Git done (by process-git-requests). build and upload ready |